You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "fmaretic (via GitHub)" <gi...@apache.org> on 2025/05/01 08:26:54 UTC
[PR] NIFI-13531 ExecuteSQLRecord not honouring FlowFile attributes for con… [nifi]
fmaretic opened a new pull request, #9909:
URL: https://github.com/apache/nifi/pull/9909
…figured RecordWriter.
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-13531](https://issues.apache.org/jira/browse/NIFI-13531)
These are the following changes:
- New MockCsvRecordWriter utility class with a fluent builder and an option to configure a dynamic separator.
- Changes to existing MockRecordWriter class to support dynamic separators.
- Bugfix in the RecordSqlWriter class that was providing an empty Map instead of the original attributes when constructing a RecordSetWriter.
One thing to note here is that this could (in theory) break some existing flows if the users are aware of the issue and made some workarounds for it. This is in fact a breaking change if the users are not relying on this behavior.
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [x] Pull Request based on current revision of the `main` branch
- [x] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [x] Build completed using `mvn clean install -P contrib-check`
- [x] JDK 21
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-13531 ExecuteSQLRecord not honouring FlowFile attributes for con… [nifi]
Posted by "joewitt (via GitHub)" <gi...@apache.org>.
joewitt commented on PR #9909:
URL: https://github.com/apache/nifi/pull/9909#issuecomment-2993696172
@markap14 This change looks good to me and the tests seem helpful. Can you review as I dont think I appreciate the potentially breaking nature of it in carrying through attributes...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-13531 ExecuteSQLRecord not honouring FlowFile attributes for con… [nifi]
Posted by "fmaretic (via GitHub)" <gi...@apache.org>.
fmaretic commented on PR #9909:
URL: https://github.com/apache/nifi/pull/9909#issuecomment-3444260521
Hello @exceptionfactory , I have rebased the branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-13531 ExecuteSQLRecord not honouring FlowFile attributes for con… [nifi]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9909:
URL: https://github.com/apache/nifi/pull/9909#issuecomment-3420102201
Automated review is marking this PR as stale due to lack of updates in the past four months. This PR will be closed in 15 days if the stale label is not removed. This stale label and automated closure does not indicate a judgement of the PR, just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale label. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-13531 ExecuteSQLRecord not honouring FlowFile attributes for con… [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory merged PR #9909:
URL: https://github.com/apache/nifi/pull/9909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org