You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/09/27 13:05:49 UTC

[PR] Delegate SQL support checks to providers [shardingsphere]

terrymanu opened a new pull request, #39980:
URL: https://github.com/apache/shardingsphere/pull/39980

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Delegate SQL support checks to providers [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39980:
URL: https://github.com/apache/shardingsphere/pull/39980#issuecomment-5856127089

   ### Result
   
   **Review Result: Mergeable**
   
   I found no code changes to request in the SQL Federation patch. The Engine delegates SQL eligibility to the selected Provider; Calcite remains SELECT-only, and NONE rejects all statements as requested.
   
   ### Review Recommendations
   
   - Exclude the two untracked `.pyc` files under `.codex/skills/` from the commit. They are unrelated generated artifacts.
   - State the intentional SPI compatibility break in the commit or PR description: external `SQLFederationProvider` implementations must now implement `isSupportedSQLStatement(SQLStatement)`.
   - Use the relocated core Engine test for validation. The former Calcite-module test command succeeds while selecting **zero tests**.
   
   ### Evidence
   
   The source-fresh module run passed **302 tests** across core, NONE, and Calcite, with no failures. Exact-file Spotless and Checkstyle checks and Apache RAT passed after the last source change. The predicate changes routing; it does not add end-to-end DML federation execution.
   
   ### Coverage
   
   Reviewed all **16 uncommitted paths** against `be22a27d23f8c4208e7cb69dd6bccc357229259b`: 14 SQL Federation source, test, and test-resource paths, plus the two bytecode artifacts. This is a local code review; CI was not reviewed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Delegate SQL support checks to providers [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39980:
URL: https://github.com/apache/shardingsphere/pull/39980


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org