You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by "Konrad Windszus (Jira)" <ji...@apache.org> on 2022/05/13 17:14:00 UTC

[jira] [Comment Edited] (MSKINS-182) Fix padding of search input form

    [ https://issues.apache.org/jira/browse/MSKINS-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536506#comment-17536506 ] 

Konrad Windszus edited comment on MSKINS-182 at 5/13/22 5:13 PM:
-----------------------------------------------------------------

This is still not properly centered after https://github.com/apache/maven-fluido-skin/commit/ce84a312dee11becf2c37ff6b32694bcb030e5df:

 !Screenshot 2022-05-13 at 10.33.55.png! 

The reason seems to be the padding set in https://github.com/apache/maven-fluido-skin/blob/90c24e96283b2816a0c995ee7a696c5c51767b98/src/main/resources/css/bootstrap-2.3.2.css#L1095.

[~michael-o] We probably need to overwrite those bootstrap styles to make the padding on the right and left hand side the same. It is unclear to me, why bootstrap decided for that asymmetrical alignment, but maybe for non-centered input fields this looks better.


was (Author: kwin):
This is still not properly centered after https://github.com/apache/maven-fluido-skin/commit/ce84a312dee11becf2c37ff6b32694bcb030e5df:

 !Screenshot 2022-05-13 at 10.33.55.png! 

The reason seems to be the rounded borders (https://developer.mozilla.org/en-US/docs/Web/CSS/border-radius)

> Fix padding of search input form
> --------------------------------
>
>                 Key: MSKINS-182
>                 URL: https://issues.apache.org/jira/browse/MSKINS-182
>             Project: Maven Skins
>          Issue Type: Bug
>          Components: Fluido Skin
>    Affects Versions: fluido-1.10.0
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>            Priority: Major
>         Attachments: Screenshot 2022-05-13 at 10.33.55.png, screenshot-1.png
>
>
> The padding is currently out of bounds:
>  !screenshot-1.png! 
> Make the search input form inside the bounds of the div element.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)