[GitHub] [tvm] mbrookhart commented on a change in pull request #7044: [TOPI] GPU scatter_add using atomic

[GitBox <gi...@apache.org>]

mbrookhart commented on a change in pull request #7044:
URL: https://github.com/apache/tvm/pull/7044#discussion_r537647724



##########
File path: tests/python/frontend/pytorch/test_forward.py
##########
@@ -3355,12 +3355,12 @@ def test_bincount():
     def test_fn(x, weights=None):
         return torch.bincount(x, weights=weights)
 
-    inp = torch.randint(0, 8, (5,), dtype=torch.int64)
-    weights = torch.linspace(0, 1, steps=5)
+    inp = torch.randint(0, 100, (10000,), dtype=torch.int64)
+    weights = torch.linspace(0, 100, steps=10000)
 
-    verify_trace_model(test_fn, [inp], ["llvm"])
-    verify_trace_model(test_fn, [inp, weights], ["llvm"])
-    verify_trace_model(test_fn, [inp, weights.to(torch.float64)], ["llvm"])

Review comment:
       I assume you removed this because the atomic add isn't precise enough for float64?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org