You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4cxx-dev@logging.apache.org by af...@apache.org on 2006/08/13 21:54:29 UTC

svn commit: r431218 - in /logging/log4cxx/trunk/src: hierarchy.cpp inetaddress.cpp obsoleterollingfileappender.cpp writerappender.cpp

Author: afester
Date: Sun Aug 13 12:54:29 2006
New Revision: 431218

URL: http://svn.apache.org/viewvc?rev=431218&view=rev
Log:
LOGCXX-14: fixed initialization order of members (fix gcc warning
... is initialized before ...)

Modified:
    logging/log4cxx/trunk/src/hierarchy.cpp
    logging/log4cxx/trunk/src/inetaddress.cpp
    logging/log4cxx/trunk/src/obsoleterollingfileappender.cpp
    logging/log4cxx/trunk/src/writerappender.cpp

Modified: logging/log4cxx/trunk/src/hierarchy.cpp
URL: http://svn.apache.org/viewvc/logging/log4cxx/trunk/src/hierarchy.cpp?rev=431218&r1=431217&r2=431218&view=diff
==============================================================================
--- logging/log4cxx/trunk/src/hierarchy.cpp (original)
+++ logging/log4cxx/trunk/src/hierarchy.cpp Sun Aug 13 12:54:29 2006
@@ -40,8 +40,9 @@
 IMPLEMENT_LOG4CXX_OBJECT(Hierarchy)
 
 Hierarchy::Hierarchy(const LoggerPtr& root1) : root(root1),
+thresholdInt(Level::ALL_INT), threshold(Level::getAll()),
 emittedNoAppenderWarning(false), emittedNoResourceBundleWarning(false),
-mutex(), configured(false), thresholdInt(Level::ALL_INT), threshold(Level::getAll())
+mutex(), configured(false)
 {
         this->root->setHierarchy(this);
         defaultFactory = new DefaultCategoryFactory();

Modified: logging/log4cxx/trunk/src/inetaddress.cpp
URL: http://svn.apache.org/viewvc/logging/log4cxx/trunk/src/inetaddress.cpp?rev=431218&r1=431217&r2=431218&view=diff
==============================================================================
--- logging/log4cxx/trunk/src/inetaddress.cpp (original)
+++ logging/log4cxx/trunk/src/inetaddress.cpp Sun Aug 13 12:54:29 2006
@@ -42,7 +42,7 @@
 
 
 InetAddress::InetAddress(const LogString& hostName, const LogString& hostAddr) 
-    : hostNameString(hostName), ipAddrString(hostAddr) {
+    : ipAddrString(hostAddr), hostNameString(hostName) {
 }
 
 

Modified: logging/log4cxx/trunk/src/obsoleterollingfileappender.cpp
URL: http://svn.apache.org/viewvc/logging/log4cxx/trunk/src/obsoleterollingfileappender.cpp?rev=431218&r1=431217&r2=431218&view=diff
==============================================================================
--- logging/log4cxx/trunk/src/obsoleterollingfileappender.cpp (original)
+++ logging/log4cxx/trunk/src/obsoleterollingfileappender.cpp Sun Aug 13 12:54:29 2006
@@ -39,17 +39,16 @@
 
 
 RollingFileAppender::RollingFileAppender()
-   : rfa(new log4cxx::rolling::RollingFileAppender()),
-     maxFileSize(10*1024*1024), maxBackupIndex(1) {
+   : maxFileSize(10*1024*1024), maxBackupIndex(1),
+     rfa(new log4cxx::rolling::RollingFileAppender()) {
 }
 
 RollingFileAppender::RollingFileAppender(
   const LayoutPtr& layout,
   const LogString& filename,
   bool append)
-  : rfa(new log4cxx::rolling::RollingFileAppender()),
-  maxFileSize(10*1024*1024),
-  maxBackupIndex(1)  {
+  : maxFileSize(10*1024*1024), maxBackupIndex(1),
+    rfa(new log4cxx::rolling::RollingFileAppender()) {
   rfa->setLayout(layout);
   rfa->setFile(filename);
   rfa->setAppend(append);
@@ -59,9 +58,8 @@
 
 RollingFileAppender::RollingFileAppender(const LayoutPtr& layout,
    const LogString& filename)
-   : rfa(new log4cxx::rolling::RollingFileAppender()),
-   maxFileSize(10*1024*1024),
-   maxBackupIndex(1) {
+   : maxFileSize(10*1024*1024), maxBackupIndex(1),
+     rfa(new log4cxx::rolling::RollingFileAppender()) {
   rfa->setLayout(layout);
   rfa->setFile(filename);
   Pool pool;

Modified: logging/log4cxx/trunk/src/writerappender.cpp
URL: http://svn.apache.org/viewvc/logging/log4cxx/trunk/src/writerappender.cpp?rev=431218&r1=431217&r2=431218&view=diff
==============================================================================
--- logging/log4cxx/trunk/src/writerappender.cpp (original)
+++ logging/log4cxx/trunk/src/writerappender.cpp Sun Aug 13 12:54:29 2006
@@ -32,7 +32,7 @@
 
 WriterAppender::WriterAppender(const LayoutPtr& layout1,
                log4cxx::helpers::WriterPtr& writer1)
-    : AppenderSkeleton(layout1), writer(writer1), immediateFlush(true) {
+    : AppenderSkeleton(layout1), immediateFlush(true), writer(writer1) {
       Pool p;
       activateOptions(p);
 }