You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by "John Sisson (JIRA)" <ji...@codehaus.org> on 2006/05/16 15:45:42 UTC

[jira] Created: (MAVEN-1761) org.apache.maven.MavenUtils.loadProperties(..) does not close the FileInputStream (relying upon finalization)

org.apache.maven.MavenUtils.loadProperties(..) does not close the FileInputStream (relying upon finalization)
-------------------------------------------------------------------------------------------------------------

         Key: MAVEN-1761
         URL: http://jira.codehaus.org/browse/MAVEN-1761
     Project: Maven
        Type: Bug

  Components: core  
    Versions: 1.1-beta-2    
    Reporter: John Sisson
     Fix For: 1.1-beta-3
 Attachments: MavenUtils.patch

org.apache.maven.MavenUtils.loadProperties(..) does not close the FileInputStream (relying upon finalization)

See attached patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Updated: (MAVEN-1761) org.apache.maven.MavenUtils.loadProperties(..) does not close the FileInputStream (relying upon finalization)

Posted by "John Sisson (JIRA)" <ji...@codehaus.org>.

     [ http://jira.codehaus.org/browse/MAVEN-1761?page=all ]

John Sisson updated MAVEN-1761:
-------------------------------

    Attachment: JellyScriptHousing.patch

> org.apache.maven.MavenUtils.loadProperties(..) does not close the FileInputStream (relying upon finalization)
> -------------------------------------------------------------------------------------------------------------
>
>          Key: MAVEN-1761
>          URL: http://jira.codehaus.org/browse/MAVEN-1761
>      Project: Maven
>         Type: Bug

>   Components: core
>     Versions: 1.1-beta-2
>     Reporter: John Sisson
>      Fix For: 1.1-beta-3
>  Attachments: JellyScriptHousing.patch, MavenUtils.patch
>
>
> org.apache.maven.MavenUtils.loadProperties(..) does not close the FileInputStream (relying upon finalization)
> See attached patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Commented: (MAVEN-1761) org.apache.maven.MavenUtils.loadProperties(..) does not close the FileInputStream (relying upon finalization)

Posted by "John Sisson (JIRA)" <ji...@codehaus.org>.

    [ http://jira.codehaus.org/browse/MAVEN-1761?page=comments#action_65453 ] 

John Sisson commented on MAVEN-1761:
------------------------------------

Also in MavenUtils, the getNonJellyProject(..) method does not close the FileReader that is created.

> org.apache.maven.MavenUtils.loadProperties(..) does not close the FileInputStream (relying upon finalization)
> -------------------------------------------------------------------------------------------------------------
>
>          Key: MAVEN-1761
>          URL: http://jira.codehaus.org/browse/MAVEN-1761
>      Project: Maven
>         Type: Bug

>   Components: core
>     Versions: 1.1-beta-2
>     Reporter: John Sisson
>      Fix For: 1.1-beta-3
>  Attachments: JellyScriptHousing.patch, MavenUtils.patch
>
>
> org.apache.maven.MavenUtils.loadProperties(..) does not close the FileInputStream (relying upon finalization)
> See attached patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Commented: (MAVEN-1761) org.apache.maven.MavenUtils.loadProperties(..) does not close the FileInputStream (relying upon finalization)

Posted by "John Sisson (JIRA)" <ji...@codehaus.org>.

    [ http://jira.codehaus.org/browse/MAVEN-1761?page=comments#action_65455 ] 

John Sisson commented on MAVEN-1761:
------------------------------------

Similar problems with the compileScript and runScript methods in JellyUtils.java where a FileInputStream is not closed.

> org.apache.maven.MavenUtils.loadProperties(..) does not close the FileInputStream (relying upon finalization)
> -------------------------------------------------------------------------------------------------------------
>
>          Key: MAVEN-1761
>          URL: http://jira.codehaus.org/browse/MAVEN-1761
>      Project: Maven
>         Type: Bug

>   Components: core
>     Versions: 1.1-beta-2
>     Reporter: John Sisson
>      Fix For: 1.1-beta-3
>  Attachments: JellyScriptHousing.patch, MavenUtils.patch
>
>
> org.apache.maven.MavenUtils.loadProperties(..) does not close the FileInputStream (relying upon finalization)
> See attached patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Closed: (MAVEN-1761) org.apache.maven.MavenUtils.loadProperties(..) does not close the FileInputStream (relying upon finalization)

Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.

     [ http://jira.codehaus.org/browse/MAVEN-1761?page=all ]
     
Arnaud Heritier closed MAVEN-1761:
----------------------------------

    Resolution: Fixed

I checked that we close all the InputStreams we open.

> org.apache.maven.MavenUtils.loadProperties(..) does not close the FileInputStream (relying upon finalization)
> -------------------------------------------------------------------------------------------------------------
>
>          Key: MAVEN-1761
>          URL: http://jira.codehaus.org/browse/MAVEN-1761
>      Project: Maven
>         Type: Bug

>   Components: core
>     Versions: 1.1-beta-2
>     Reporter: John Sisson
>     Assignee: Arnaud Heritier
>      Fix For: 1.1-beta-3
>  Attachments: JellyScriptHousing.patch, MavenUtils.patch
>
>
> org.apache.maven.MavenUtils.loadProperties(..) does not close the FileInputStream (relying upon finalization)
> See attached patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira