You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sid Wagle <sw...@hortonworks.com> on 2014/05/15 00:52:28 UTC

Review Request 21466: Blueprint delete throws exception

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21466/
-----------------------------------------------------------

Review request for Ambari, John Speidel, Mahadev Konar, and Tom Beerbower.


Bugs: AMBARI-5767
    https://issues.apache.org/jira/browse/AMBARI-5767


Repository: ambari


Description
-------

DELETE 
ambariHost:8080/api/v1/blueprints/myBlueprint

results in 500 error:
18:08:10,817  WARN [qtp1102737706-22] ServletHandler:514 - /api/v1/blueprints/newhadoopcluster
java.lang.StringIndexOutOfBoundsException: String index out of range: -1
        at java.lang.String.substring(String.java:1911)
        at org.apache.ambari.server.controller.internal.BlueprintResourceProvider.createConfigEntities(BlueprintResourceProvider.java:395)
        at org.apache.ambari.server.controller.internal.BlueprintResourceProvider.toEntity(BlueprintResourceProvider.java:311)
        at org.apache.ambari.server.controller.internal.BlueprintResourceProvider$1.invoke(BlueprintResourceProvider.java:206)
        at org.apache.ambari.server.controller.internal.BlueprintResourceProvider$1.invoke(BlueprintResourceProvider.java:203)


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java 003590f 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/BlueprintDAO.java 0cbaedc 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java b611551 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/BlueprintDAOTest.java c157729 

Diff: https://reviews.apache.org/r/21466/diff/


Testing
-------


Thanks,

Sid Wagle

Re: Review Request 21466: Blueprint delete throws exception

Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21466/#review43066
-----------------------------------------------------------

Ship it!


Ship It!

- Mahadev Konar


On May 15, 2014, 12:10 a.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21466/
> -----------------------------------------------------------
> 
> (Updated May 15, 2014, 12:10 a.m.)
> 
> 
> Review request for Ambari, John Speidel, Mahadev Konar, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-5767
>     https://issues.apache.org/jira/browse/AMBARI-5767
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> DELETE 
> ambariHost:8080/api/v1/blueprints/myBlueprint
> 
> results in 500 error:
> 18:08:10,817  WARN [qtp1102737706-22] ServletHandler:514 - /api/v1/blueprints/newhadoopcluster
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
>         at java.lang.String.substring(String.java:1911)
>         at org.apache.ambari.server.controller.internal.BlueprintResourceProvider.createConfigEntities(BlueprintResourceProvider.java:395)
>         at org.apache.ambari.server.controller.internal.BlueprintResourceProvider.toEntity(BlueprintResourceProvider.java:311)
>         at org.apache.ambari.server.controller.internal.BlueprintResourceProvider$1.invoke(BlueprintResourceProvider.java:206)
>         at org.apache.ambari.server.controller.internal.BlueprintResourceProvider$1.invoke(BlueprintResourceProvider.java:203)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java 003590f 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/BlueprintDAO.java 0cbaedc 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java b611551 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/BlueprintDAOTest.java c157729 
> 
> Diff: https://reviews.apache.org/r/21466/diff/
> 
> 
> Testing
> -------
> 
> Reproduced exception and verified the fix.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 21466: Blueprint delete throws exception

Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21466/#review43116
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
<https://reviews.apache.org/r/21466/#comment77129>

    should remove toEntity as it is no longer used



ambari-server/src/main/java/org/apache/ambari/server/orm/dao/BlueprintDAO.java
<https://reviews.apache.org/r/21466/#comment77128>

    What happens if null is passed into remove?


- John Speidel


On May 15, 2014, 12:10 a.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21466/
> -----------------------------------------------------------
> 
> (Updated May 15, 2014, 12:10 a.m.)
> 
> 
> Review request for Ambari, John Speidel, Mahadev Konar, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-5767
>     https://issues.apache.org/jira/browse/AMBARI-5767
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> DELETE 
> ambariHost:8080/api/v1/blueprints/myBlueprint
> 
> results in 500 error:
> 18:08:10,817  WARN [qtp1102737706-22] ServletHandler:514 - /api/v1/blueprints/newhadoopcluster
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
>         at java.lang.String.substring(String.java:1911)
>         at org.apache.ambari.server.controller.internal.BlueprintResourceProvider.createConfigEntities(BlueprintResourceProvider.java:395)
>         at org.apache.ambari.server.controller.internal.BlueprintResourceProvider.toEntity(BlueprintResourceProvider.java:311)
>         at org.apache.ambari.server.controller.internal.BlueprintResourceProvider$1.invoke(BlueprintResourceProvider.java:206)
>         at org.apache.ambari.server.controller.internal.BlueprintResourceProvider$1.invoke(BlueprintResourceProvider.java:203)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java 003590f 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/BlueprintDAO.java 0cbaedc 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java b611551 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/BlueprintDAOTest.java c157729 
> 
> Diff: https://reviews.apache.org/r/21466/diff/
> 
> 
> Testing
> -------
> 
> Reproduced exception and verified the fix.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 21466: Blueprint delete throws exception

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21466/
-----------------------------------------------------------

(Updated May 15, 2014, 12:10 a.m.)


Review request for Ambari, John Speidel, Mahadev Konar, and Tom Beerbower.


Bugs: AMBARI-5767
    https://issues.apache.org/jira/browse/AMBARI-5767


Repository: ambari


Description
-------

DELETE 
ambariHost:8080/api/v1/blueprints/myBlueprint

results in 500 error:
18:08:10,817  WARN [qtp1102737706-22] ServletHandler:514 - /api/v1/blueprints/newhadoopcluster
java.lang.StringIndexOutOfBoundsException: String index out of range: -1
        at java.lang.String.substring(String.java:1911)
        at org.apache.ambari.server.controller.internal.BlueprintResourceProvider.createConfigEntities(BlueprintResourceProvider.java:395)
        at org.apache.ambari.server.controller.internal.BlueprintResourceProvider.toEntity(BlueprintResourceProvider.java:311)
        at org.apache.ambari.server.controller.internal.BlueprintResourceProvider$1.invoke(BlueprintResourceProvider.java:206)
        at org.apache.ambari.server.controller.internal.BlueprintResourceProvider$1.invoke(BlueprintResourceProvider.java:203)


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java 003590f 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/BlueprintDAO.java 0cbaedc 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java b611551 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/BlueprintDAOTest.java c157729 

Diff: https://reviews.apache.org/r/21466/diff/


Testing (updated)
-------

Reproduced exception and verified the fix.


Thanks,

Sid Wagle

Re: Review Request 21466: Blueprint delete throws exception

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21466/
-----------------------------------------------------------

(Updated May 14, 2014, 10:54 p.m.)


Review request for Ambari, John Speidel, Mahadev Konar, and Tom Beerbower.


Changes
-------

Unit tests passed.


Bugs: AMBARI-5767
    https://issues.apache.org/jira/browse/AMBARI-5767


Repository: ambari


Description
-------

DELETE 
ambariHost:8080/api/v1/blueprints/myBlueprint

results in 500 error:
18:08:10,817  WARN [qtp1102737706-22] ServletHandler:514 - /api/v1/blueprints/newhadoopcluster
java.lang.StringIndexOutOfBoundsException: String index out of range: -1
        at java.lang.String.substring(String.java:1911)
        at org.apache.ambari.server.controller.internal.BlueprintResourceProvider.createConfigEntities(BlueprintResourceProvider.java:395)
        at org.apache.ambari.server.controller.internal.BlueprintResourceProvider.toEntity(BlueprintResourceProvider.java:311)
        at org.apache.ambari.server.controller.internal.BlueprintResourceProvider$1.invoke(BlueprintResourceProvider.java:206)
        at org.apache.ambari.server.controller.internal.BlueprintResourceProvider$1.invoke(BlueprintResourceProvider.java:203)


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java 003590f 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/BlueprintDAO.java 0cbaedc 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java b611551 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/BlueprintDAOTest.java c157729 

Diff: https://reviews.apache.org/r/21466/diff/


Testing
-------


Thanks,

Sid Wagle