You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/15 17:35:15 UTC

[GitHub] [arrow] sweb commented on pull request #8880: ARROW-10927: [Rust][Parquet] Add Decimal to ArrayBuilderReader

sweb commented on pull request #8880:
URL: https://github.com/apache/arrow/pull/8880#issuecomment-745447636


   > > I used the same JIRA issue here - I hope that this is okay.
   > 
   > Please open a separate JIRA 😃
   > 
   > The Parquet spec supports reading decimal data from a few other types (`i32`, `i64`, `binary`) https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#decimal.
   > 
   > I think reading from `FixedSizeList` is a good start, but we should tackle the other types at some point. Also see #8926 where I've made similar changes.
   
   @nevi-me thank you for your review! I have opened a [new issue](https://issues.apache.org/jira/browse/ARROW-10926) with a [subtask](https://issues.apache.org/jira/browse/ARROW-10927) specific to this PR. I will try to provide implementations for missing types (I only considered fixed size binary, since this is what I get from Spark ;)) and add the corresponding writers as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org