[jira] [Comment Edited] (TAP5-2373) Add a Tabs component

["Lance (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-2373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102386#comment-14102386 ] 

Lance edited comment on TAP5-2373 at 8/19/14 4:20 PM:
------------------------------------------------------

Hi, I've had a quick look and it looks like you've gone with a similar approach to the tapestry-jquery tabs here
http://tapestry5-jquery.com/components/docsjquerytabs

I don't really like this approach as it requires 'magic' parameter names.

Have you considered having tab components nested within a tabGroup similar to these:
http://tapestry-stitch.uklance.cloudbees.net/tabgroupdemo
http://jumpstart.doublenegative.com.au/jumpstart7/examples/navigation/tabs

This approach of using two component types allows each tab to have it's own distinct (and validated) model. I feel that this approach is more future proof than 'magic' parameter names.




was (Author: uklance):
Hi, I've had a quick look and it looks like you've gone with a similar approach to the tapestry-jquery tabs here
http://tapestry5-jquery.com/components/docsjquerytabs

I don't really like this approach as it requires 'magic' parameter names.

Have you considered having tab components nested within a tabGroup similar to this:
http://tapestry-stitch.uklance.cloudbees.net/tabgroupdemo

This allows each tab to have it's own attributes and is a bit more future proof than magic parameter names.

> Add a Tabs component
> --------------------
>
>                 Key: TAP5-2373
>                 URL: https://issues.apache.org/jira/browse/TAP5-2373
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.4
>            Reporter: Felix Scheffer
>              Labels: patch
>         Attachments: 0001-Tabs-component.patch
>
>
> I think it would be nice if Tapestry would have a component for tabs out of the box.
> The patch file contains some kind of initial draft. It is very similar to bootstrap/tab.js but uses the t5/core/dom module instead of jquery. There's probably room for improvements, especially because it's the first time I actually wrote something in CoffeeScript.
> Currently it does support "fade" and you can customize the name of a tab (e.g. adding icons to the tab name).
> It does not support dropdown tabs (see bootstrap) and there's no support for ajax tabs at the moment.



--
This message was sent by Atlassian JIRA
(v6.2#6252)