You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Chenxi Li (Jira)" <ji...@apache.org> on 2021/06/07 05:37:00 UTC

[jira] [Updated] (ARROW-12984) [C++] Passing options parameter of Count/Index aggregation by reference

     [ https://issues.apache.org/jira/browse/ARROW-12984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chenxi Li updated ARROW-12984:
------------------------------
    Summary: [C++] Passing options parameter of Count/Index aggregation by reference  (was: [C++] Passing options parameter of Count aggregation by reference)

> [C++] Passing options parameter of Count/Index aggregation by reference
> -----------------------------------------------------------------------
>
>                 Key: ARROW-12984
>                 URL: https://issues.apache.org/jira/browse/ARROW-12984
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Chenxi Li
>            Assignee: Chenxi Li
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The {{options}} parameter of Count function in {{api_aggregate.h}} is passed by value, it's better to be passed by reference like other functions.
> {code:c++}
> Result<Datum> Count(const Datum& value, ScalarAggregateOptions options, ExecContext* ctx)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)