You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/30 20:57:25 UTC

[GitHub] [incubator-nuttx] patacongo commented on pull request #1152: tools/Makefiles: Fix use of unbuilt incdir binary

patacongo commented on pull request #1152:
URL: https://github.com/apache/incubator-nuttx/pull/1152#issuecomment-636384570


   > I am thinking that the cause of the performance degradation is that INCDIR is defined only once when Config.mk is first included. After the true tools/incdir binary is created, the INCDIR definition is not updated and continues to use incdir.sh, ruining perfromance.
   
   If we accept the changes to Makefile.win and Makefile.unix but ignor the bad changes to Config.mk, then all of the errors about failing to find the indir binary disapper except four that occur during configuration.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org