[jira] [Commented] (SOLR-14290) Fix NPE in SolrTestCaseJ4 breaking external usage for master/9.x

["Jan Høydahl (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-14290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470201#comment-17470201 ] 

Jan Høydahl commented on SOLR-14290:
------------------------------------

I don't think this should hold up the 9.0 releae. Users depending on the test framework outside of Solr can be warned in the "Upgrade notes" about a known limitation, and then it can be fixed for 9.0.1. But if there is a solution coming up, feel free to merge it in!

> Fix NPE in SolrTestCaseJ4 breaking external usage for master/9.x
> ----------------------------------------------------------------
>
>                 Key: SOLR-14290
>                 URL: https://issues.apache.org/jira/browse/SOLR-14290
>             Project: Solr
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 9.0
>         Environment: Solr Test Framework when run externally such that ExternalPaths.SOURCE_HOME is null
>            Reporter: Gus Heck
>            Assignee: Gus Heck
>            Priority: Blocker
>             Fix For: 9.0
>
>
> A fix for this was provided on branch_8x in SOLR-14283 but that same fix won't work in java 11 due to reflection restrictions that make it impossible (AFAIK) to un-final a final variable. We will likely need to employ powermock or our own java agent based solution, or redesign the way ExternalPaths.determinSourceHome and ExternalPaths.SOURCE_HOME work. 
> 8.5 is coming up soon and we can't release with this broken in 8.5 so I'm separating the more complicated 9x fix into this ticket.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org