You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Steven Gill <st...@gmail.com> on 2015/01/06 22:22:18 UTC
Cordova-lib failing on master (stopping release)
Commit:
https://github.com/apache/cordova-lib/commit/197c49a1727fab676543595867aa3557966f7d12
Travis:
https://github.com/apache/cordova-lib/commit/197c49a1727fab676543595867aa3557966f7d12
I am going to revert this commit unless you guys think it is necessary. If
so, we need to fix these tests ASAP so I can continue release.
-Steve
Re: Cordova-lib failing on master (stopping release)
Posted by Andrew Grieve <ag...@chromium.org>.
Gar, thanks for reverting and moving on. Sorry for not running tests :(
On Tue, Jan 6, 2015 at 5:54 PM, Steven Gill <st...@gmail.com> wrote:
> Yup. I reverted to that commit. Pushed to master. Continuing with release.
>
> On Tue, Jan 6, 2015 at 2:46 PM, Mark Koudritsky <ka...@google.com> wrote:
>
> > This commit
> >
> >
> https://github.com/apache/cordova-lib/commit/b2e33f55e98f23116066f47f9b6ea5b49474d95c
> > passed on both AppVeyor
> > <https://ci.appveyor.com/project/Humbedooh/cordova-lib/build/1.0.333>
> and
> > Travis <https://travis-ci.org/apache/cordova-lib/builds/45818232>
> >
>
Re: Cordova-lib failing on master (stopping release)
Posted by Steven Gill <st...@gmail.com>.
Yup. I reverted to that commit. Pushed to master. Continuing with release.
On Tue, Jan 6, 2015 at 2:46 PM, Mark Koudritsky <ka...@google.com> wrote:
> This commit
>
> https://github.com/apache/cordova-lib/commit/b2e33f55e98f23116066f47f9b6ea5b49474d95c
> passed on both AppVeyor
> <https://ci.appveyor.com/project/Humbedooh/cordova-lib/build/1.0.333> and
> Travis <https://travis-ci.org/apache/cordova-lib/builds/45818232>
>
Re: Cordova-lib failing on master (stopping release)
Posted by Mark Koudritsky <ka...@google.com>.
This commit
https://github.com/apache/cordova-lib/commit/b2e33f55e98f23116066f47f9b6ea5b49474d95c
passed on both AppVeyor
<https://ci.appveyor.com/project/Humbedooh/cordova-lib/build/1.0.333> and
Travis <https://travis-ci.org/apache/cordova-lib/builds/45818232>
Re: Cordova-lib failing on master (stopping release)
Posted by Jesse <pu...@gmail.com>.
Yes please do.
This type of work should be done in a branch, and at least smoke tested on
windows+mac before being pushed.
It is also broken in appveyor tests, although that seems like it might be
an issue with the commit before.
@purplecabbage
risingj.com
On Tue, Jan 6, 2015 at 1:22 PM, Steven Gill <st...@gmail.com> wrote:
> Commit:
>
> https://github.com/apache/cordova-lib/commit/197c49a1727fab676543595867aa3557966f7d12
>
> Travis:
>
> https://github.com/apache/cordova-lib/commit/197c49a1727fab676543595867aa3557966f7d12
>
> I am going to revert this commit unless you guys think it is necessary. If
> so, we need to fix these tests ASAP so I can continue release.
>
> -Steve
>