[GitHub] [qpid-jms] tabish121 commented on a change in pull request #30: QPIDJMS-461 Optimize the default message ID builder

[GitBox <gi...@apache.org>]

tabish121 commented on a change in pull request #30: QPIDJMS-461 Optimize the default message ID builder
URL: https://github.com/apache/qpid-jms/pull/30#discussion_r294500728
 
 

 ##########
 File path: qpid-jms-client/src/main/java/org/apache/qpid/jms/message/JmsMessageIDBuilder.java
 ##########
 @@ -115,6 +119,20 @@ public String toString() {
         public static JmsMessageIDBuilder create(String value) {
             return valueOf(value.toUpperCase(Locale.ENGLISH)).createBuilder();
         }
+
+        /**
+         * Validates the value given maps to the built in message ID builders and
+         * return the builder enumeration that it maps to which can later be used
+         * to create builders of that type.
+         *
+         * @param value
+         * 		The name of one of the built in message ID builders.
+         *
+         * @return the enumeration value that maps to the built in builder.
+         */
+        public static BUILTIN validate(String value) {
+            return valueOf(value.toUpperCase(Locale.ENGLISH));
 
 Review comment:
   I fixed that and pushed a new update for this change

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org