You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2007/03/08 16:56:45 UTC

svn commit: r516083 - /jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/reporters/Summariser.java

Author: sebb
Date: Thu Mar  8 07:56:44 2007
New Revision: 516083

URL: http://svn.apache.org/viewvc?view=rev&rev=516083
Log:
Update Javadoc - explain why delta can take longer than reporting interval

Modified:
    jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/reporters/Summariser.java

Modified: jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/reporters/Summariser.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/reporters/Summariser.java?view=diff&rev=516083&r1=516082&r2=516083
==============================================================================
--- jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/reporters/Summariser.java (original)
+++ jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/reporters/Summariser.java Thu Mar  8 07:56:44 2007
@@ -43,6 +43,14 @@
  * 
  * This is mainly intended for batch (non-GUI) runs
  * 
+ * Note that the RunningSample start and end times relate to the samples,
+ * not the reporting interval.
+ * 
+ * Since the first sample in a delta is likely to have started in the previous reporting interval,
+ * this means that the delta interval is likely to be longer than the reporting interval.
+ * 
+ * Also, the sum of the delta intervals will be larger than the overall elapsed time.
+ * 
  */
 public class Summariser extends AbstractTestElement implements Serializable, SampleListener, TestListener, Clearable {
 	private static final Logger log = LoggingManager.getLoggerForClass();
@@ -144,16 +152,16 @@
 		}
 	}
 
-	/**
+	/*
 	 * Cached copy of Totals for this instance.
-     * These do not need to be synchronised,
+     * The variables do not need to be synchronised,
      * as they are not shared between threads
 	 */
 	transient private Totals myTotals = null;
 
 	transient private String myName;
 
-	/**
+	/*
 	 * Ensure that a report is not skipped if we are slightly late in checking
 	 * the time.
 	 */
@@ -208,18 +216,22 @@
 		if (reportNow) {
 			String str;
 			str = format(myDelta, "+");
-			if (TOLOG)
+			if (TOLOG) {
 				log.info(str);
-			if (TOOUT)
+			}
+			if (TOOUT) {
 				System.out.println(str);
+			}
 
 			// Only if we have updated them
 			if (myTotal.getNumSamples() != myDelta.getNumSamples()) {
 				str = format(myTotal, "=");
-				if (TOLOG)
+				if (TOLOG) {
 					log.info(str);
-				if (TOOUT)
+				}
+				if (TOOUT) {
 					System.out.println(str);
+				}
 			}
 		}
 	}



---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org