You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/04/25 00:49:57 UTC

[GitHub] [dubbo-go-samples] AlexStocks commented on a change in pull request #97: add readme of game

AlexStocks commented on a change in pull request #97:
URL: https://github.com/apache/dubbo-go-samples/pull/97#discussion_r619729414



##########
File path: game/README.md
##########
@@ -6,7 +6,263 @@
 - The two services communicate with each other RPC (both registered **provider** and **consumer**)
 - The **gate** additionally starts the http service (port **8000**), which is used to manually trigger the **gate** RPC to call **game**
 
-> After each **gate** RPC call (**Message**) **game**, **game** will synchronize the RPC call (Send) **gate** pushes the same message
-> This logic is annotated by default, and the location is `go-server-game/pkg/provider.go` (line 25 ~ 30)
+> Each time **gate** RPC calls (**message**) **game**, **game** will synchronously call RPC (send) **gate** to push the same message. There are two services in samples, one is basketball service, the other is jumpservice. The jumpservice part has been commented out, and the content is basically the same as basketball.

Review comment:
       ”has been commented out“  => has been ramarked. 另外,如果已经注释掉,何不直接删掉算了?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org