[jira] [Commented] (TS-4000) Extraneous `setvbuf()` in Diags.cc

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14994486#comment-14994486 ] 

ASF GitHub Bot commented on TS-4000:
------------------------------------

GitHub user danobi opened a pull request:

    https://github.com/apache/trafficserver/pull/325

    TS-4000 Extraneous `setvbuf()` in Diags.cc

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/danobi/trafficserver TS-4000

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/325.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #325
    
----
commit 9df9201ef8add813856b731e384b146b0a107b0e
Author: Daniel Xu <dl...@yahoo.com>
Date:   2015-11-06T21:14:30Z

    TS-4000 Extraneous `setvbuf()` in Diags.cc
    
    Remove the extra `setvbuf()` because `setlinebuf()` is called in
    `BaseLogFile::open_file()` right beforehand.

commit 6b429222b30be123597cee7905a144e324286bda
Author: Daniel Xu <dl...@yahoo.com>
Date:   2015-11-06T21:38:31Z

    clang-format

----


> Extraneous `setvbuf()` in Diags.cc
> ----------------------------------
>
>                 Key: TS-4000
>                 URL: https://issues.apache.org/jira/browse/TS-4000
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Logging
>            Reporter: Daniel Xu
>
> Line 596:
> {noformat}
> status = setvbuf(blf->m_fp, NULL, _IOLBF, 512);
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)