You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ps...@apache.org on 2012/07/15 18:26:57 UTC
svn commit: r1361731 -
/commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericObjectPoolConfig.java
Author: psteitz
Date: Sun Jul 15 16:26:57 2012
New Revision: 1361731
URL: http://svn.apache.org/viewvc?rev=1361731&view=rev
Log:
Added no-arg constructor.
Modified:
commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericObjectPoolConfig.java
Modified: commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericObjectPoolConfig.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericObjectPoolConfig.java?rev=1361731&r1=1361730&r2=1361731&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericObjectPoolConfig.java (original)
+++ commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericObjectPoolConfig.java Sun Jul 15 16:26:57 2012
@@ -54,7 +54,9 @@ public class GenericObjectPoolConfig ext
private int minIdle = DEFAULT_MIN_IDLE;
-
+ public GenericObjectPoolConfig() {
+ }
+
public int getMaxTotal() {
return maxTotal;
}
Re: svn commit: r1361731 - /commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericObjectPoolConfig.java
Posted by Phil Steitz <ph...@gmail.com>.
I am OK leaving it out. I added it to make it consistent with gkopconfig and in case we add other constructors, which I guess we won't, so I am OK to axe (and same for gkop)
On Jul 15, 2012, at 10:08 AM, Mark Thomas <ma...@apache.org> wrote:
> On 15/07/2012 17:26, psteitz@apache.org wrote:
>> Author: psteitz
>> Date: Sun Jul 15 16:26:57 2012
>> New Revision: 1361731
>>
>> URL: http://svn.apache.org/viewvc?rev=1361731&view=rev
>> Log:
>> Added no-arg constructor.
>
> Why? That is just pointless code. I have been trying to remove that sort
> of thing from pool2.
>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1361731 - /commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericObjectPoolConfig.java
Posted by Mark Thomas <ma...@apache.org>.
On 15/07/2012 17:26, psteitz@apache.org wrote:
> Author: psteitz
> Date: Sun Jul 15 16:26:57 2012
> New Revision: 1361731
>
> URL: http://svn.apache.org/viewvc?rev=1361731&view=rev
> Log:
> Added no-arg constructor.
Why? That is just pointless code. I have been trying to remove that sort
of thing from pool2.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org