You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by am...@apache.org on 2016/10/27 04:24:35 UTC
svn commit: r1766761 - in /jackrabbit/oak/trunk: oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/ oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/ oak-segment/src/main/java/org/apache/jackrabbit/oak/plugins/segment/

Author: amitj
Date: Thu Oct 27 04:24:35 2016
New Revision: 1766761

URL: http://svn.apache.org/viewvc?rev=1766761&view=rev
Log:
OAK-5014: Minor description change for OSGi blobTrackSnapshotIntervalInSecs property

Added a note about recommended frequency to be less than datastore GC frequency.

Modified:
    jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreService.java
    jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentNodeStoreService.java
    jackrabbit/oak/trunk/oak-segment/src/main/java/org/apache/jackrabbit/oak/plugins/segment/SegmentNodeStoreService.java

Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreService.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreService.java?rev=1766761&r1=1766760&r2=1766761&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreService.java (original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreService.java Thu Oct 27 04:24:35 2016
@@ -344,7 +344,9 @@ public class DocumentNodeStoreService {
     @Property (longValue = DEFAULT_BLOB_SNAPSHOT_INTERVAL,
         label = "Blob tracking snapshot interval (in secs)",
         description = "This is the default interval in which the snapshots of locally tracked blob ids will"
-            + "be taken and synchronized with the blob store"
+            + "be taken and synchronized with the blob store. This should be configured to be less than the "
+            + "frequency of blob GC so that deletions during blob GC can be accounted for "
+            + "in the next GC execution."
     )
     public static final String PROP_BLOB_SNAPSHOT_INTERVAL = "blobTrackSnapshotIntervalInSecs";
 

Modified: jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentNodeStoreService.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentNodeStoreService.java?rev=1766761&r1=1766760&r2=1766761&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentNodeStoreService.java (original)
+++ jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentNodeStoreService.java Thu Oct 27 04:24:35 2016
@@ -291,7 +291,9 @@ public class SegmentNodeStoreService ext
     @Property (longValue = DEFAULT_BLOB_SNAPSHOT_INTERVAL,
         label = "Blob tracking snapshot interval (in secs)",
         description = "This is the default interval in which the snapshots of locally tracked blob ids will"
-            + "be taken and synchronized with the blob store"
+            + "be taken and synchronized with the blob store. This should be configured to be less than the "
+            + "frequency of blob GC so that deletions during blob GC can be accounted for "
+            + "in the next GC execution."
     )
     public static final String PROP_BLOB_SNAPSHOT_INTERVAL = "blobTrackSnapshotIntervalInSecs";
 

Modified: jackrabbit/oak/trunk/oak-segment/src/main/java/org/apache/jackrabbit/oak/plugins/segment/SegmentNodeStoreService.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-segment/src/main/java/org/apache/jackrabbit/oak/plugins/segment/SegmentNodeStoreService.java?rev=1766761&r1=1766760&r2=1766761&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-segment/src/main/java/org/apache/jackrabbit/oak/plugins/segment/SegmentNodeStoreService.java (original)
+++ jackrabbit/oak/trunk/oak-segment/src/main/java/org/apache/jackrabbit/oak/plugins/segment/SegmentNodeStoreService.java Thu Oct 27 04:24:35 2016
@@ -316,7 +316,9 @@ public class SegmentNodeStoreService ext
     @Property (longValue = DEFAULT_BLOB_SNAPSHOT_INTERVAL,
         label = "Blob tracking snapshot interval (in secs)",
         description = "This is the default interval in which the snapshots of locally tracked blob ids will"
-            + "be taken and synchronized with the blob store"
+            + "be taken and synchronized with the blob store. This should be configured to be less than the "
+            + "frequency of blob GC so that deletions during blob GC can be accounted for "
+            + "in the next GC execution."
     )
     public static final String PROP_BLOB_SNAPSHOT_INTERVAL = "blobTrackSnapshotIntervalInSecs";