[jira] [Commented] (NIFI-2689) better foreground run for nifi.sh to improve supervision

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446025#comment-15446025 ] 

ASF GitHub Bot commented on NIFI-2689:
--------------------------------------

Github user automaticgiant commented on the issue:

    https://github.com/apache/nifi/pull/966
  
    https://issues.apache.org/jira/browse/NIFI-2689



> better foreground run for nifi.sh to improve supervision
> --------------------------------------------------------
>
>                 Key: NIFI-2689
>                 URL: https://issues.apache.org/jira/browse/NIFI-2689
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Tools and Build
>    Affects Versions: 1.0.0
>         Environment: *nix
>            Reporter: Hunter Morgan
>            Priority: Minor
>              Labels: easyfix, patch
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The launch script (nifi.sh) has a run argument that "supports" running in foreground. This could be useful with supervisors such as runit, however, the indirection provided by a subshell and an eval allow the instance to be detached from the session in certain circumstances and break trivial compatibility with runit.
> Adding an exec to RUN_NIFI_CMD before the sudo prefix, and removing the subshell invocation from the start argument else is a fix for my purposes. Something more considerate may be better. Additionally, if the feature should be desired in other similar launcher scripts, if there is an upstream source of that pattern I'm unaware of, it should be similarly modified.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)