You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Joe Orton <jo...@redhat.com> on 2000/11/22 12:23:51 UTC
[PATCH] 1.3: mend DSO detection on Linux
The performance tweak to Configure in revision 1.408 broke the DSO
detection stuff on Linux... here is a fix:
Index: src/Configure
===================================================================
RCS file: /home/joe/lib/cvsroot/apache-1.3/src/Configure,v
retrieving revision 1.411
diff -u -r1.411 Configure
--- src/Configure 2000/11/14 09:56:50 1.411
+++ src/Configure 2000/11/22 11:18:17
@@ -1055,7 +1055,7 @@
LDFLAGS_MOD_SHLIB=$LDFLAGS_SHLIB
LDFLAGS_SHLIB_EXPORT="-rdynamic"
;;
- *-linux2)
+ *-linux2*)
LD_SHLIB="gcc"
CFLAGS_SHLIB="-fpic"
LDFLAGS_SHLIB="-shared"
Re: [PATCH] 1.3: mend DSO detection on Linux
Posted by Jeff Trawick <tr...@bellsouth.net>.
Joe Orton <jo...@redhat.com> writes:
> That's weird, are you sure you've got the latest GuessOS, rev 1.70? The
> only lines left that I can see do:
Oops... I'm updating my 1.3 tree now...
--
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
http://www.geocities.com/SiliconValley/Park/9289/
Born in Roswell... married an alien...
Re: [PATCH] 1.3: mend DSO detection on Linux
Posted by Joe Orton <jo...@redhat.com>.
On 28 Nov 2000, Jeff Trawick wrote:
> By the way, what is GuessOS returning on your box? I can't verify your fix on
> my machine. On my RH 6.0 box, I get "i686-whatever-linux2" so I would
> expect the current code to work fine for me (and many other Linux boxen).
That's weird, are you sure you've got the latest GuessOS, rev 1.70? The
only lines left that I can see do:
Linux:2.0.*)
echo "${MACHINE}-whatever-linux20"; exit 0
;;
Linux:[2-9].*)
echo "${MACHINE}-whatever-linux22"; exit 0
;;
On RHL 6.2:
$ ./src/helpers/GuessOS
i686-whatever-linux22
Regards,
joe
Re: [PATCH] 1.3: mend DSO detection on Linux
Posted by Jeff Trawick <tr...@bellsouth.net>.
Joe Orton <jo...@redhat.com> writes:
> The performance tweak to Configure in revision 1.408 broke the DSO
> detection stuff on Linux... here is a fix:
>
> Index: src/Configure
> ===================================================================
> RCS file: /home/joe/lib/cvsroot/apache-1.3/src/Configure,v
> retrieving revision 1.411
> diff -u -r1.411 Configure
> --- src/Configure 2000/11/14 09:56:50 1.411
> +++ src/Configure 2000/11/22 11:18:17
> @@ -1055,7 +1055,7 @@
> LDFLAGS_MOD_SHLIB=$LDFLAGS_SHLIB
> LDFLAGS_SHLIB_EXPORT="-rdynamic"
> ;;
> - *-linux2)
> + *-linux2*)
> LD_SHLIB="gcc"
> CFLAGS_SHLIB="-fpic"
> LDFLAGS_SHLIB="-shared"
By the way, what is GuessOS returning on your box? I can't verify your fix on
my machine. On my RH 6.0 box, I get "i686-whatever-linux2" so I would
expect the current code to work fine for me (and many other Linux boxen).
not doubting, just looking for a way to double check before committing...
--
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
http://www.geocities.com/SiliconValley/Park/9289/
Born in Roswell... married an alien...