[GitHub] [tvm] electriclilies commented on pull request #9848: [Relay] [Virtual Device] Store function result virtual device in virtual_device_ field

[GitBox <gi...@apache.org>]

electriclilies commented on pull request #9848:
URL: https://github.com/apache/tvm/pull/9848#issuecomment-1033315487


   @mbs-octoml OK, so I ended up changing the parser to parse the virtual device in for the tests. I'm not married to the syntax-- right now I'm just putting the virtual device right after the return type of the function, separated by a comma.  I'm thinking this will generalize well to parameter types. 
   
   So for now it''s like this: 
   
   `fn main(%x: Tensor([1, 2, 3])) -> Tensor([1, 2, 3, 4]), virtual_device:meta[VirtualDevice][1] {
   body }`
   
   One thing I wasn't sure about was the approach for keywords in the parser-- I couldn't find where the keywords are checked, so I just am letting virtual_device be any identifier for now. @jroesch any insight on this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org