[GitHub] rymanluk commented on issue #351: Bt5 extended advertising - host part

[gi...@git.apache.org]

rymanluk commented on issue #351: Bt5 extended advertising - host part
URL: https://github.com/apache/incubator-mynewt-core/pull/351#issuecomment-311371565
 
 
   Thanks for review.
   1) your right however in practice it works. I did it because I was remember that patch
   
   433aab55c nimble host test; change the way empty struct is initialized to get this to compile on linux gcc.
   But I see now that problem there was probably due to struct inside struct.
   
   Anyway, fixed.
   
   2) Fixed
   3) Fixed
   4) Fixed
   5) BLE_LL_CFG_FEAT_LL_EXT_ADV is there to keep consistency with other features which are present in supported features mask.  Actually with new patchset I move BLE_EXT_ADV into 'nimble/syscfg.yml'. Idea is that user application will set only this flag to configure host and controller. E.g. also for blehci
   So maybe indeed BLE_LL_CFG_FEAT_LL_EXT_ADV could be just  #define inside controller  code which would depend on BLE_EXT_ADV. In general current configuration looks good to me. The only problem we could have with it is when somebody manually set BLE_LL_CFG_FEAT_LL_EXT_ADV and not BLE_EXT_ADV. In this case some build errors shows up in hci code I guess.
   
   Lets wait for Will comment on this.
   Also that can be fixed in separate patch once we came to the conclusion.
   
   6) ups I missed that somehow. Should be fixed now.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services