You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Bertrand Guay-Paquet (JIRA)" <ji...@apache.org> on 2012/07/26 17:05:35 UTC
[jira] [Created] (WICKET-4676) Relax restrictions on url of
ExternalUrlResourceReference
Bertrand Guay-Paquet created WICKET-4676:
--------------------------------------------
Summary: Relax restrictions on url of ExternalUrlResourceReference
Key: WICKET-4676
URL: https://issues.apache.org/jira/browse/WICKET-4676
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 6.0.0-beta3
Reporter: Bertrand Guay-Paquet
Priority: Minor
ExternalUrlResourceReference allows using a url as a resource reference. Currently, the class requires that the url be absolute. I couldn't find a reason for this restriction and my tests show the class works without it.
This issue is to remove the absoluteness restriction for the url. This will allow referencing resources on the same server root as Wicket, but which are not managed by Wicket.
Email thread discussing the issue: http://mail-archives.apache.org/mod_mbox/wicket-dev/201207.mbox/%3CCAMomwMqSJFY%3DVDNQCSwZQQV9AP-MZu2Jwb-zUmv6%2B6zzbdMA7A%40mail.gmail.com%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (WICKET-4676) Relax restrictions on url of
ExternalUrlResourceReference and rename it to UrlResourceReference
Posted by "Bertrand Guay-Paquet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bertrand Guay-Paquet closed WICKET-4676.
----------------------------------------
> Relax restrictions on url of ExternalUrlResourceReference and rename it to UrlResourceReference
> -----------------------------------------------------------------------------------------------
>
> Key: WICKET-4676
> URL: https://issues.apache.org/jira/browse/WICKET-4676
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 6.0.0-beta3
> Reporter: Bertrand Guay-Paquet
> Assignee: Martin Grigorov
> Priority: Minor
> Labels: resources, url
> Fix For: 6.0.0
>
> Attachments: changes.diff
>
>
> ExternalUrlResourceReference allows using a url as a resource reference. Currently, the class requires that the url be absolute. I couldn't find a reason for this restriction and my tests show the class works without it.
> This issue is to remove the absoluteness restriction for the url. This will allow referencing resources on the same server root as Wicket, but which are not managed by Wicket.
> Email thread discussing the issue: http://mail-archives.apache.org/mod_mbox/wicket-dev/201207.mbox/%3CCAMomwMqSJFY%3DVDNQCSwZQQV9AP-MZu2Jwb-zUmv6%2B6zzbdMA7A%40mail.gmail.com%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4676) Relax restrictions on url of
ExternalUrlResourceReference
Posted by "Bertrand Guay-Paquet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423131#comment-13423131 ]
Bertrand Guay-Paquet commented on WICKET-4676:
----------------------------------------------
ExternalUrlResourceReference was introduced in WICKET-4466
> Relax restrictions on url of ExternalUrlResourceReference
> ---------------------------------------------------------
>
> Key: WICKET-4676
> URL: https://issues.apache.org/jira/browse/WICKET-4676
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 6.0.0-beta3
> Reporter: Bertrand Guay-Paquet
> Priority: Minor
> Labels: resources, url
>
> ExternalUrlResourceReference allows using a url as a resource reference. Currently, the class requires that the url be absolute. I couldn't find a reason for this restriction and my tests show the class works without it.
> This issue is to remove the absoluteness restriction for the url. This will allow referencing resources on the same server root as Wicket, but which are not managed by Wicket.
> Email thread discussing the issue: http://mail-archives.apache.org/mod_mbox/wicket-dev/201207.mbox/%3CCAMomwMqSJFY%3DVDNQCSwZQQV9AP-MZu2Jwb-zUmv6%2B6zzbdMA7A%40mail.gmail.com%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4676) Relax restrictions on url of
ExternalUrlResourceReference
Posted by "Bertrand Guay-Paquet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bertrand Guay-Paquet updated WICKET-4676:
-----------------------------------------
Attachment: changes.diff
Proposed changes. I did not rename the class to reduce the size of the patch, but I think it should be done as well. I propose the name "UrlResourceReference"
> Relax restrictions on url of ExternalUrlResourceReference
> ---------------------------------------------------------
>
> Key: WICKET-4676
> URL: https://issues.apache.org/jira/browse/WICKET-4676
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 6.0.0-beta3
> Reporter: Bertrand Guay-Paquet
> Priority: Minor
> Labels: resources, url
> Attachments: changes.diff
>
>
> ExternalUrlResourceReference allows using a url as a resource reference. Currently, the class requires that the url be absolute. I couldn't find a reason for this restriction and my tests show the class works without it.
> This issue is to remove the absoluteness restriction for the url. This will allow referencing resources on the same server root as Wicket, but which are not managed by Wicket.
> Email thread discussing the issue: http://mail-archives.apache.org/mod_mbox/wicket-dev/201207.mbox/%3CCAMomwMqSJFY%3DVDNQCSwZQQV9AP-MZu2Jwb-zUmv6%2B6zzbdMA7A%40mail.gmail.com%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4676) Relax restrictions on url of
ExternalUrlResourceReference and rename it to UrlResourceReference
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-4676:
------------------------------------
Summary: Relax restrictions on url of ExternalUrlResourceReference and rename it to UrlResourceReference (was: Relax restrictions on url of ExternalUrlResourceReference)
> Relax restrictions on url of ExternalUrlResourceReference and rename it to UrlResourceReference
> -----------------------------------------------------------------------------------------------
>
> Key: WICKET-4676
> URL: https://issues.apache.org/jira/browse/WICKET-4676
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 6.0.0-beta3
> Reporter: Bertrand Guay-Paquet
> Priority: Minor
> Labels: resources, url
> Attachments: changes.diff
>
>
> ExternalUrlResourceReference allows using a url as a resource reference. Currently, the class requires that the url be absolute. I couldn't find a reason for this restriction and my tests show the class works without it.
> This issue is to remove the absoluteness restriction for the url. This will allow referencing resources on the same server root as Wicket, but which are not managed by Wicket.
> Email thread discussing the issue: http://mail-archives.apache.org/mod_mbox/wicket-dev/201207.mbox/%3CCAMomwMqSJFY%3DVDNQCSwZQQV9AP-MZu2Jwb-zUmv6%2B6zzbdMA7A%40mail.gmail.com%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4676) Relax restrictions on url of
ExternalUrlResourceReference and rename it to UrlResourceReference
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-4676.
-------------------------------------
Resolution: Fixed
Fix Version/s: 6.0.0
Assignee: Martin Grigorov
All suggestions are applied.
> Relax restrictions on url of ExternalUrlResourceReference and rename it to UrlResourceReference
> -----------------------------------------------------------------------------------------------
>
> Key: WICKET-4676
> URL: https://issues.apache.org/jira/browse/WICKET-4676
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 6.0.0-beta3
> Reporter: Bertrand Guay-Paquet
> Assignee: Martin Grigorov
> Priority: Minor
> Labels: resources, url
> Fix For: 6.0.0
>
> Attachments: changes.diff
>
>
> ExternalUrlResourceReference allows using a url as a resource reference. Currently, the class requires that the url be absolute. I couldn't find a reason for this restriction and my tests show the class works without it.
> This issue is to remove the absoluteness restriction for the url. This will allow referencing resources on the same server root as Wicket, but which are not managed by Wicket.
> Email thread discussing the issue: http://mail-archives.apache.org/mod_mbox/wicket-dev/201207.mbox/%3CCAMomwMqSJFY%3DVDNQCSwZQQV9AP-MZu2Jwb-zUmv6%2B6zzbdMA7A%40mail.gmail.com%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira