You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/01/28 06:58:11 UTC
[GitHub] [skywalking] LIU-WEI-git opened a new pull request #8484: Bump up iotdb-session to 0.12.4 and fix IoTDB storage option bug
LIU-WEI-git opened a new pull request #8484:
URL: https://github.com/apache/skywalking/pull/8484
1. Fix IoTDB Storage Option insert null index value.
2. Set the default value of SW_STORAGE_IOTDB_SESSIONPOOL_SIZE to 2 * CPU_Cores
3. Bump up iotdb-session to 0.12.4
- [*] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] LIU-WEI-git commented on a change in pull request #8484: Bump up iotdb-session to 0.12.4 and fix IoTDB storage option bug
Posted by GitBox <gi...@apache.org>.
LIU-WEI-git commented on a change in pull request #8484:
URL: https://github.com/apache/skywalking/pull/8484#discussion_r795062980
##########
File path: oap-server/server-starter/src/main/resources/application.yml
##########
@@ -258,7 +258,7 @@ storage:
username: ${SW_STORAGE_IOTDB_USERNAME:root}
password: ${SW_STORAGE_IOTDB_PASSWORD:root}
storageGroup: ${SW_STORAGE_IOTDB_STORAGE_GROUP:root.skywalking}
- sessionPoolSize: ${SW_STORAGE_IOTDB_SESSIONPOOL_SIZE:16}
+ sessionPoolSize: ${SW_STORAGE_IOTDB_SESSIONPOOL_SIZE:8} # If it's zero, the SessionPool size will be 2*CPU_Cores
Review comment:
Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] LIU-WEI-git commented on a change in pull request #8484: Bump up iotdb-session to 0.12.4 and fix IoTDB storage option bug
Posted by GitBox <gi...@apache.org>.
LIU-WEI-git commented on a change in pull request #8484:
URL: https://github.com/apache/skywalking/pull/8484#discussion_r795023715
##########
File path: docs/en/setup/backend/backend-storage.md
##########
@@ -294,7 +294,7 @@ storage:
username: ${SW_STORAGE_IOTDB_USERNAME:root}
password: ${SW_STORAGE_IOTDB_PASSWORD:root}
storageGroup: ${SW_STORAGE_IOTDB_STORAGE_GROUP:root.skywalking}
- sessionPoolSize: ${SW_STORAGE_IOTDB_SESSIONPOOL_SIZE:0} # Zero means the size is 2*CPU_Cores
+ sessionPoolSize: ${SW_STORAGE_IOTDB_SESSIONPOOL_SIZE:8} # Zero means the size is 2*CPU_Cores
Review comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] LIU-WEI-git commented on a change in pull request #8484: Bump up iotdb-session to 0.12.4 and fix IoTDB storage option bug
Posted by GitBox <gi...@apache.org>.
LIU-WEI-git commented on a change in pull request #8484:
URL: https://github.com/apache/skywalking/pull/8484#discussion_r795019311
##########
File path: CHANGES.md
##########
@@ -45,6 +45,9 @@ Release Notes.
* Fix `SelfRemoteClient` self observing metrics.
* Add env variables `SW_CLUSTER_INTERNAL_COM_HOST` and `SW_CLUSTER_INTERNAL_COM_PORT` for cluster selectors `zookeeper`,`consul`,`etcd` and `nacos`.
* Doc update: `configuration-vocabulary`,`backend-cluster` about env variables `SW_CLUSTER_INTERNAL_COM_HOST` and `SW_CLUSTER_INTERNAL_COM_PORT`.
+* Fix IoTDB Storage Option insert null index value.
+* Set the default value of SW_STORAGE_IOTDB_SESSIONPOOL_SIZE to 2 * CPU_Cores.
Review comment:
The default value of SW_STORAGE_IOTDB_SESSIONPOOL_SIZE is 8, while 2 for low-resource e2e.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #8484: Bump up iotdb-session to 0.12.4 and fix IoTDB storage option bug
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #8484:
URL: https://github.com/apache/skywalking/pull/8484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #8484: Bump up iotdb-session to 0.12.4 and fix IoTDB storage option bug
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #8484:
URL: https://github.com/apache/skywalking/pull/8484#discussion_r794247221
##########
File path: CHANGES.md
##########
@@ -45,6 +45,9 @@ Release Notes.
* Fix `SelfRemoteClient` self observing metrics.
* Add env variables `SW_CLUSTER_INTERNAL_COM_HOST` and `SW_CLUSTER_INTERNAL_COM_PORT` for cluster selectors `zookeeper`,`consul`,`etcd` and `nacos`.
* Doc update: `configuration-vocabulary`,`backend-cluster` about env variables `SW_CLUSTER_INTERNAL_COM_HOST` and `SW_CLUSTER_INTERNAL_COM_PORT`.
+* Fix IoTDB Storage Option insert null index value.
+* Set the default value of SW_STORAGE_IOTDB_SESSIONPOOL_SIZE to 2 * CPU_Cores.
Review comment:
Should be less? Check PersistenceTimer codes, the default prepare thread is only 2.
```java
prepareExecutorService = Executors.newFixedThreadPool(moduleConfig.getPrepareThreads());
```
How many threads are you building in the bulk metric and segment processing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #8484: Bump up iotdb-session to 0.12.4 and fix IoTDB storage option bug
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #8484:
URL: https://github.com/apache/skywalking/pull/8484#issuecomment-1024928590
Let's see whether IoTDB cases could be more stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #8484: Bump up iotdb-session to 0.12.4 and fix IoTDB storage option bug
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #8484:
URL: https://github.com/apache/skywalking/pull/8484#discussion_r795049835
##########
File path: oap-server/server-starter/src/main/resources/application.yml
##########
@@ -258,7 +258,7 @@ storage:
username: ${SW_STORAGE_IOTDB_USERNAME:root}
password: ${SW_STORAGE_IOTDB_PASSWORD:root}
storageGroup: ${SW_STORAGE_IOTDB_STORAGE_GROUP:root.skywalking}
- sessionPoolSize: ${SW_STORAGE_IOTDB_SESSIONPOOL_SIZE:16}
+ sessionPoolSize: ${SW_STORAGE_IOTDB_SESSIONPOOL_SIZE:8} # If it's zero, the SessionPool size will be 2*CPU_Cores
Review comment:
`configuration-vocabulary.md` should be updated accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #8484: Bump up iotdb-session to 0.12.4 and fix IoTDB storage option bug
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #8484:
URL: https://github.com/apache/skywalking/pull/8484#discussion_r795020170
##########
File path: docs/en/setup/backend/backend-storage.md
##########
@@ -294,7 +294,7 @@ storage:
username: ${SW_STORAGE_IOTDB_USERNAME:root}
password: ${SW_STORAGE_IOTDB_PASSWORD:root}
storageGroup: ${SW_STORAGE_IOTDB_STORAGE_GROUP:root.skywalking}
- sessionPoolSize: ${SW_STORAGE_IOTDB_SESSIONPOOL_SIZE:0} # Zero means the size is 2*CPU_Cores
+ sessionPoolSize: ${SW_STORAGE_IOTDB_SESSIONPOOL_SIZE:8} # Zero means the size is 2*CPU_Cores
Review comment:
Please adjust the comments to follow the codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org