[GitHub] [spark] cloud-fan commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r721861588



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -80,8 +80,8 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
         writeOptions = c.writeOptions,
         orCreate = c.orCreate)
 
-    case UseStatement(isNamespaceSet, nameParts) =>
-      if (isNamespaceSet) {
+    case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>

Review comment:
       shall we have a single place to resolve `UnresolvedDBObjectName`? Currently it's resolved in L34 in this file




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org