You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jay Guo <gu...@cn.ibm.com> on 2016/12/02 08:49:28 UTC
Review Request 54301: Introduced 'roles' validation in master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54301/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Leveraged validateRoles method introduced in previous patch to
validate FrameworkInfo when a framework subscribes to master.
Diffs
-----
src/master/master.cpp e03a2e8025943825a2902102c43dc0eb66bacb6a
Diff: https://reviews.apache.org/r/54301/diff/
Testing
-------
Thanks,
Jay Guo
Re: Review Request 54301: Introduced 'roles' validation in master.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54301/#review157750
-----------------------------------------------------------
Ship it!
It is better always adding something in `Testing Done` section and for this one, you can probaly add following to make sure that your code build and test passed.
```
make
make check
```
- Guangya Liu
On \u5341\u4e8c\u6708 2, 2016, 8:51 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54301/
> -----------------------------------------------------------
>
> (Updated \u5341\u4e8c\u6708 2, 2016, 8:51 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Guangya Liu.
>
>
> Bugs: MESOS-6629
> https://issues.apache.org/jira/browse/MESOS-6629
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Leveraged validateRoles method introduced in previous patch to
> validate FrameworkInfo when a framework subscribes to master.
>
>
> Diffs
> -----
>
> src/master/master.cpp e03a2e8025943825a2902102c43dc0eb66bacb6a
>
> Diff: https://reviews.apache.org/r/54301/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 54301: Introduced 'roles' validation in master.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54301/#review157843
-----------------------------------------------------------
Ship it!
src/master/master.cpp (lines 2382 - 2386)
<https://reviews.apache.org/r/54301/#comment228451>
Per Qian's suggestion, can you move the failover timeout validation into `validation::framework::validate()`?
I'd suggest doing this in another patch and adding a test for the valid framework timeout (if there is a test it will have to be an integration test, so let's change it into a unit test if the integration test exists).
Then, in another patch, we can add a version of `validation::framework::validate(Master*, const FrameworkInfo&)` which takes the master to perform the validation that needs the master's state.
- Benjamin Mahler
On Dec. 2, 2016, 8:51 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54301/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2016, 8:51 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Guangya Liu.
>
>
> Bugs: MESOS-6629
> https://issues.apache.org/jira/browse/MESOS-6629
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Leveraged validateRoles method introduced in previous patch to
> validate FrameworkInfo when a framework subscribes to master.
>
>
> Diffs
> -----
>
> src/master/master.cpp e03a2e8025943825a2902102c43dc0eb66bacb6a
>
> Diff: https://reviews.apache.org/r/54301/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 54301: Introduced 'roles' validation in master.
Posted by Jay Guo <gu...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54301/
-----------------------------------------------------------
(Updated Dec. 2, 2016, 8:51 a.m.)
Review request for mesos, Benjamin Mahler and Guangya Liu.
Bugs: MESOS-6629
https://issues.apache.org/jira/browse/MESOS-6629
Repository: mesos
Description
-------
Leveraged validateRoles method introduced in previous patch to
validate FrameworkInfo when a framework subscribes to master.
Diffs
-----
src/master/master.cpp e03a2e8025943825a2902102c43dc0eb66bacb6a
Diff: https://reviews.apache.org/r/54301/diff/
Testing
-------
Thanks,
Jay Guo