[GitHub] mobidev111 opened a new issue #270: description tag set to default instead of defined value - regression from 5.0.0

[GitBox <gi...@apache.org>]

mobidev111 opened a new issue #270: description tag set to default instead of defined value - regression from 5.0.0
URL: https://github.com/apache/cordova-windows/issues/270
 
 
   The <description> tag is set to a default value instead of the in the config.xml defined value. This is is a regression from cordova-windows 5.0.0.
   
   ### situation
   macOS host machine
   cordova-lib: 8.1.0
   cordova-windows 6.0.0
   
   A description is correctly set in config.xml:
   
   config.xml
   ```
     <description>
       Demo
     </description>
   ```
   
   when running on a mac (not windows):
   ```
   cordova prepare
   ```
   
   ### actual
   
   platforms/windows/config.xml contains an additional description tag (with default content), in addition to the customized description tag
   ```
     <description>
       A sample Apache Cordova application that responds to the deviceready event.
     </description>
     [...]
     <description>
       Demo
     </description>
   ```
   
   The appxmanifest files contain only the default value instead of the set custom value:
   platforms/windows/package.phone.appxmanifest
   platforms/windows/package.windows.appxmanifest
   platforms/windows/package.windows10.appxmanifest
   ```
   -        <Description>Demo</Description>
   +        <Description>A sample Apache Cordova application that responds to the deviceready event.</Description>
   ```
   ```
   -            <m2:VisualElements Description="Demo" DisplayName="Demo">
   +            <m2:VisualElements Description="A sample Apache Cordova application that responds to the deviceready event." DisplayName="Demo">
   ```
   ### expected
   
   the correctly set description tag gets propagated.
   
   ### conditions
   
   * happens only on with cordova-windows 6.0.0 - doesn't happen when using cordova-windows 5.0.0 with an otherwise unchanged setup
   
   * happens only on mac - generating on windows doesn't produce this artefact - however this a serious problem, as the generated code could be committed by mistake
   
   * probable cause: in 6.0.0 the defaults.xml contains a default value for the desciption tag for the first time.
   
   The wrong description value comes form the defaults.xml, however the <name> and <author> tags get processed correctly:
   platforms/windows/cordova/defaults.xml
   ```
       <description>
           A sample Apache Cordova application that responds to the deviceready event.
       </description>
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org