[jira] [Work logged] (BEAM-3746) Count.globally should override getIncompatibleGlobalWindowErrorMessage to tell the user the usage that is currently only in javadoc

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-3746?focusedWorklogId=92298&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-92298 ]

ASF GitHub Bot logged work on BEAM-3746:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Apr/18 23:34
            Start Date: 18/Apr/18 23:34
    Worklog Time Spent: 10m 
      Work Description: huygaa11 opened a new pull request #5176: [BEAM-3746] Added error message for using Count.globally() on non-global windows
URL: https://github.com/apache/beam/pull/5176
 
 
   
   
   DESCRIPTION HERE
   
   ------------------------
   
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand:
      - [ ] What the pull request does
      - [ ] Why it does it
      - [ ] How it does it
      - [ ] Why this approach
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 92298)
            Time Spent: 10m
    Remaining Estimate: 0h

> Count.globally should override getIncompatibleGlobalWindowErrorMessage to tell the user the usage that is currently only in javadoc
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-3746
>                 URL: https://issues.apache.org/jira/browse/BEAM-3746
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Batkhuyag Batsaikhan
>            Priority: Major
>              Labels: beginner, newbie, starter
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> https://beam.apache.org/documentation/sdks/javadoc/2.3.0/org/apache/beam/sdk/transforms/Count.html#globally--
> "Note: if the input collection uses a windowing strategy other than GlobalWindows, use Combine.globally(Count.<T>combineFn()).withoutDefaults() instead."
> But the actual crash a user gets is:
> "java.lang.IllegalStateException: Default values are not supported in Combine.globally() if the output PCollection is not windowed by GlobalWindows. Instead, use Combine.globally().withoutDefaults() to output an empty PCollection if the input PCollection is empty, or Combine.globally().asSingletonView() to get the default output of the CombineFn if the input PCollection is empty."
> There is a method that exists solely to make this actually useful, so we should use it!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)