You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by sirlatrom <gi...@git.apache.org> on 2017/06/06 11:27:49 UTC

[GitHub] camel pull request #1741: Prevent crash when route IDs contain dollar signs

GitHub user sirlatrom opened a pull request:

    https://github.com/apache/camel/pull/1741

    Prevent crash when route IDs contain dollar signs

    Spring Boot configured route get names like `UpdateRelationCamelRoute$$EnhancerBySpringCGLIB$$24c87b04`. The dollar signs are interpreted as group references since the `java.lang.String#replaceFirst()` method works with regular expressions. An alternative to the proposed change is to use the `java.lang.String#replace()` method, assuming users of `MetricsRoutePolicy` don't put the `##routeId##` token multiple places in the name pattern and really want to keep all but the first literal occurrence.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sirlatrom/camel patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1741.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1741
    
----
commit cf0283533908af7afa679c76839c8a5c8d4385ef
Author: Sune Keller <su...@gmail.com>
Date:   2017-06-06T11:26:41Z

    Prevent crash when route IDs contain dollar signs
    
    Spring Boot configured route get names like `UpdateRelationCamelRoute$$EnhancerBySpringCGLIB$$24c87b04`. The dollar signs are interpreted as group references since the `java.lang.String#replaceFirst()` method works with regular expressions. An alternative to the proposed change is to use the `java.lang.String#replace()` method, assuming users of `MetricsRoutePolicy` don't put the `##routeId##` token multiple places in the name pattern and really want to keep all but the first literal occurrence.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] camel pull request #1741: Prevent crash when route IDs contain dollar signs

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/camel/pull/1741


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---