[GitHub] [doris] HappenLee commented on a diff in pull request #15925: [Refactor]Merged string_value into string_ref

[GitBox <gi...@apache.org>]

HappenLee commented on code in PR #15925:
URL: https://github.com/apache/doris/pull/15925#discussion_r1072181628


##########
be/src/exprs/new_agg_fn_evaluator.cc:
##########
@@ -255,8 +255,8 @@ void NewAggFnEvaluator::SetDstSlot(const AnyVal* src, const SlotDescriptor& dst_
     case TYPE_OBJECT:
     case TYPE_QUANTILE_STATE:
     case TYPE_STRING:
-        *reinterpret_cast<StringValue*>(slot) =
-                StringValue::from_string_val(*reinterpret_cast<const StringVal*>(src));
+        //

Review Comment:
   remove the useless code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org