[GitHub] [druid] ccaominh commented on a change in pull request #9516: More efficient join filter rewrites

[GitBox <gi...@apache.org>]

ccaominh commented on a change in pull request #9516: More efficient join filter rewrites
URL: https://github.com/apache/druid/pull/9516#discussion_r393402568
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/segment/join/filter/JoinFilterAnalyzer.java
 ##########
 @@ -128,31 +183,172 @@ public static JoinFilterSplit splitFilter(
       }
     }
 
-    // List of candidates for pushdown
-    // CNF normalization will generate either
-    // - an AND filter with multiple subfilters
-    // - or a single non-AND subfilter which cannot be split further
-    List<Filter> normalizedOrClauses;
-    if (normalizedFilter instanceof AndFilter) {
-      normalizedOrClauses = ((AndFilter) normalizedFilter).getFilters();
-    } else {
-      normalizedOrClauses = Collections.singletonList(normalizedFilter);
+    List<VirtualColumn> pushDownVirtualColumns = new ArrayList<>();
 
 Review comment:
   CI (spotbugs and intellij inspections) is flagging this as unused

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org