[jira] [Commented] (AIRFLOW-6983) Disabled connection pool in CLI might be harmful

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051174#comment-17051174 ] 

ASF GitHub Bot commented on AIRFLOW-6983:
-----------------------------------------

Khrol commented on pull request #7622: [AIRFLOW-6983] Configure connection pool disabling in CLI
URL: https://github.com/apache/airflow/pull/7622
 
 
   Tasks are executed in CLI mode when connection pool to the database is disabled.
   `settings.configure_orm(disable_connection_pool=True)`
   
   While one task is run, multiple DB communications are happening while a separate connection is allocated for each of them. It results in DB failures.
   
   Default behavior might be ok but it worth making it configurable.
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Disabled connection pool in CLI might be harmful
> ------------------------------------------------
>
>                 Key: AIRFLOW-6983
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6983
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: database
>    Affects Versions: 1.10.9
>            Reporter: Igor Khrol
>            Assignee: Igor Khrol
>            Priority: Trivial
>
> Tasks are executed in CLI mode when connection pool to the database is disabled.
> `settings.configure_orm(disable_connection_pool=True)`
>  
> While one task is run, multiple DB communications are happening while a separate connection is allocated for each of them.
>  
> It results in DB failures.
>  
> Default behavior might be ok but it worth making it configurable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)