You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2020/02/04 18:54:54 UTC

[GitHub] [knox] pzampino commented on a change in pull request #252: KNOX-2207 - TokenStateService revocation should remove persisted token state

pzampino commented on a change in pull request #252: KNOX-2207 - TokenStateService revocation should remove persisted token state
URL: https://github.com/apache/knox/pull/252#discussion_r374856659
 
 

 ##########
 File path: gateway-server/src/main/java/org/apache/knox/gateway/services/token/impl/DefaultTokenStateService.java
 ##########
 @@ -160,7 +156,8 @@ public void revokeToken(final JWTToken token) {
   @Override
   public void revokeToken(final String token) {
     validateToken(token);
 
 Review comment:
   If removeToken() invokes validateToken(), then we can skip the validateToken() call here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services