[GitHub] [ignite] nizhikov commented on a change in pull request #7495: IGNITE-12745: Compute job view implemented.

[GitBox <gi...@apache.org>]

nizhikov commented on a change in pull request #7495: IGNITE-12745: Compute job view implemented.
URL: https://github.com/apache/ignite/pull/7495#discussion_r387697966
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/spi/systemview/view/ComputeJobView.java
 ##########
 @@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.spi.systemview.view;
+
+import java.util.StringJoiner;
+import java.util.UUID;
+import org.apache.ignite.internal.processors.cache.distributed.dht.GridReservable;
+import org.apache.ignite.internal.processors.job.GridJobProcessor;
+import org.apache.ignite.internal.processors.job.GridJobWorker;
+import org.apache.ignite.lang.IgniteUuid;
+
+/**
+ * Compute job representation for a {@link SystemView}.
+ */
+public class ComputeJobView {
+    /** Job. */
+    private final GridJobWorker job;
+
+    /**
+     * @param job Job.
+     */
+    public ComputeJobView(GridJobWorker job) {
+        this.job = job;
+    }
+
+    /** @return Task id. */
+    public IgniteUuid id() {
+        return job.getJobId();
+    }
+
+    /** @return Create time. */
+    public long createTime() {
+        return job.getCreateTime();
+    }
+
+    /** @return Start time. */
+    public long startTime() {
+        return job.getStartTime();
+    }
+
+    /** @return Finish time. */
+    public long fininshTime() {
+        return job.getFinishTime();
+    }
+
+    /** @return Origin node id. */
+    public UUID originNodeId() {
+        return job.getTaskNode().id();
+    }
+
+    /** @return {@code True} if job is internal. */
+    public boolean isInternal() {
+        return job.isInternal();
+    }
+
+    /** @return {@code True} if job is finishing. */
+    public boolean isFinishing() {
+        return job.isFinishing();
+    }
+
+    /** @return {@code True} if job is timed out. */
+    public boolean isTimedOut() {
+        return job.isTimedOut();
+    }
+
+    /** @return {@code True} if ???. */
+    public boolean isSysCancelled() {
+        return job.isSystemCanceled();
+    }
+
+    /** @return {@code True} if ???. */
+    public boolean isSysStopping() {
+        return job.isSysStopping();
+    }
+
+    /** @return {@code True} if job started. */
+    public boolean isStarted() {
+        return job.isStarted();
+    }
+
+    /** @return Executor name. */
+    public String executorName() {
+        return job.executorName();
+    }
+
+    /** @return Job class name. */
 
 Review comment:
   They both are correct. I think we should use `taskName` and `taskClassName` to highlight to the user that these columns are the same as in `TASKS` view.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services