You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Ryota Egashira <eg...@yahoo-inc.com> on 2012/11/09 23:40:14 UTC

Review Request: Add static method to create URI String in HCatURI

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7993/
-----------------------------------------------------------

Review request for oozie.


Description
-------

https://issues.apache.org/jira/browse/OOZIE-1059

changes include
1. Add static method getHCatURI
2. change PARTITION_SEPARATOR from semicolon to ampersand
3. Add equals method 


This addresses bug OOZIE-1059.
    https://issues.apache.org/jira/browse/OOZIE-1059


Diffs
-----

  branches/hcat-intre/core/src/main/java/org/apache/oozie/util/HCatURI.java 1407609 
  branches/hcat-intre/core/src/test/java/org/apache/oozie/util/TestHCatURI.java 1407609 

Diff: https://reviews.apache.org/r/7993/diff/


Testing
-------


Thanks,

Ryota Egashira

Re: Review Request: Add static method to create URI String in HCatURI

Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7993/#review13319
-----------------------------------------------------------

Ship it!


Ship It!

- Mohammad Islam


On Nov. 10, 2012, 1:52 a.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7993/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2012, 1:52 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1059
> 
> changes include
> 1. Add static method getHCatURI
> 2. change PARTITION_SEPARATOR from semicolon to ampersand
> 3. Add equals method 
> 
> 
> This addresses bug OOZIE-1059.
>     https://issues.apache.org/jira/browse/OOZIE-1059
> 
> 
> Diffs
> -----
> 
>   branches/hcat-intre/core/src/main/java/org/apache/oozie/util/HCatURI.java 1407609 
>   branches/hcat-intre/core/src/test/java/org/apache/oozie/util/TestHCatURI.java 1407609 
> 
> Diff: https://reviews.apache.org/r/7993/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Re: Review Request: Add static method to create URI String in HCatURI

Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7993/#review13320
-----------------------------------------------------------


+1 committing

- Mohammad Islam


On Nov. 10, 2012, 1:52 a.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7993/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2012, 1:52 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1059
> 
> changes include
> 1. Add static method getHCatURI
> 2. change PARTITION_SEPARATOR from semicolon to ampersand
> 3. Add equals method 
> 
> 
> This addresses bug OOZIE-1059.
>     https://issues.apache.org/jira/browse/OOZIE-1059
> 
> 
> Diffs
> -----
> 
>   branches/hcat-intre/core/src/main/java/org/apache/oozie/util/HCatURI.java 1407609 
>   branches/hcat-intre/core/src/test/java/org/apache/oozie/util/TestHCatURI.java 1407609 
> 
> Diff: https://reviews.apache.org/r/7993/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Re: Review Request: Add static method to create URI String in HCatURI

Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7993/
-----------------------------------------------------------

(Updated Nov. 10, 2012, 1:52 a.m.)


Review request for oozie.


Changes
-------

thanks for review comments, Mona. I modified patch based on comments. 


Description
-------

https://issues.apache.org/jira/browse/OOZIE-1059

changes include
1. Add static method getHCatURI
2. change PARTITION_SEPARATOR from semicolon to ampersand
3. Add equals method 


This addresses bug OOZIE-1059.
    https://issues.apache.org/jira/browse/OOZIE-1059


Diffs (updated)
-----

  branches/hcat-intre/core/src/main/java/org/apache/oozie/util/HCatURI.java 1407609 
  branches/hcat-intre/core/src/test/java/org/apache/oozie/util/TestHCatURI.java 1407609 

Diff: https://reviews.apache.org/r/7993/diff/


Testing
-------


Thanks,

Ryota Egashira

Re: Review Request: Add static method to create URI String in HCatURI

Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7993/#review13314
-----------------------------------------------------------



branches/hcat-intre/core/src/main/java/org/apache/oozie/util/HCatURI.java
<https://reviews.apache.org/r/7993/#comment28578>

    add javadoc



branches/hcat-intre/core/src/main/java/org/apache/oozie/util/HCatURI.java
<https://reviews.apache.org/r/7993/#comment28579>

    add @Override tag 



branches/hcat-intre/core/src/test/java/org/apache/oozie/util/TestHCatURI.java
<https://reviews.apache.org/r/7993/#comment28580>

    if exception is caught e.g. URISyntaxException, include a fail("..") message in the catch block and pass the exception object. Same comment for other places too


- Mona Chitnis


On Nov. 9, 2012, 10:40 p.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7993/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2012, 10:40 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1059
> 
> changes include
> 1. Add static method getHCatURI
> 2. change PARTITION_SEPARATOR from semicolon to ampersand
> 3. Add equals method 
> 
> 
> This addresses bug OOZIE-1059.
>     https://issues.apache.org/jira/browse/OOZIE-1059
> 
> 
> Diffs
> -----
> 
>   branches/hcat-intre/core/src/main/java/org/apache/oozie/util/HCatURI.java 1407609 
>   branches/hcat-intre/core/src/test/java/org/apache/oozie/util/TestHCatURI.java 1407609 
> 
> Diff: https://reviews.apache.org/r/7993/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Re: Review Request: Add static method to create URI String in HCatURI

Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7993/
-----------------------------------------------------------

(Updated Nov. 9, 2012, 10:40 p.m.)


Review request for oozie.


Description
-------

https://issues.apache.org/jira/browse/OOZIE-1059

changes include
1. Add static method getHCatURI
2. change PARTITION_SEPARATOR from semicolon to ampersand
3. Add equals method 


This addresses bug OOZIE-1059.
    https://issues.apache.org/jira/browse/OOZIE-1059


Diffs
-----

  branches/hcat-intre/core/src/main/java/org/apache/oozie/util/HCatURI.java 1407609 
  branches/hcat-intre/core/src/test/java/org/apache/oozie/util/TestHCatURI.java 1407609 

Diff: https://reviews.apache.org/r/7993/diff/


Testing
-------


Thanks,

Ryota Egashira