You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/24 14:32:49 UTC
[GitHub] [airflow] mcepok opened a new pull request #14982: Recognize more ways to import DAG in ChainBetweenDAGAndOperatorNotAllowedRule
mcepok opened a new pull request #14982:
URL: https://github.com/apache/airflow/pull/14982
This solves the second issue mentioned in #13287 . The problem basically is, that currently only `from airflow.models import DAG` is recognized, but it's not unlikely, that e.g. `from airflow import models` followed by `models.DAG(...)` is used.
This PR recognizes all ways of importing / using the DAG class, as long as it is not renamed (e.g. `from airflow.models import DAG as AirflowDAG`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #14982: Recognize more ways to import DAG in ChainBetweenDAGAndOperatorNotAllowedRule
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #14982:
URL: https://github.com/apache/airflow/pull/14982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb closed pull request #14982: Recognize more ways to import DAG in ChainBetweenDAGAndOperatorNotAllowedRule
Posted by GitBox <gi...@apache.org>.
ashb closed pull request #14982:
URL: https://github.com/apache/airflow/pull/14982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mcepok commented on pull request #14982: Recognize more ways to import DAG in ChainBetweenDAGAndOperatorNotAllowedRule
Posted by GitBox <gi...@apache.org>.
mcepok commented on pull request #14982:
URL: https://github.com/apache/airflow/pull/14982#issuecomment-810880721
@ashb anything left to do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14982: Recognize more ways to import DAG in ChainBetweenDAGAndOperatorNotAllowedRule
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14982:
URL: https://github.com/apache/airflow/pull/14982#issuecomment-805876889
[The Workflow run](https://github.com/apache/airflow/actions/runs/683371880) is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14982: Recognize more ways to import DAG in ChainBetweenDAGAndOperatorNotAllowedRule
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14982:
URL: https://github.com/apache/airflow/pull/14982#issuecomment-811925739
Hmmm, why are tests not running. Lets try this once more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14982: Recognize more ways to import DAG in ChainBetweenDAGAndOperatorNotAllowedRule
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14982:
URL: https://github.com/apache/airflow/pull/14982#issuecomment-842724461
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mcepok commented on pull request #14982: Recognize more ways to import DAG in ChainBetweenDAGAndOperatorNotAllowedRule
Posted by GitBox <gi...@apache.org>.
mcepok commented on pull request #14982:
URL: https://github.com/apache/airflow/pull/14982#issuecomment-812387008
So the fails for the 2.7 images are because `from unittest.mock import patch` seems to not exists for python 2.7 . However, that PR is already merged (#14913). The fix is trivial, I can include it here or create another PR. What do you prefer @ashb ?
The other fails are related to docker
`pull access denied for prestosql/presto, repository does not exist or may require 'docker login': denied: requested access to the resource is denied`
:shrug:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14982: Recognize more ways to import DAG in ChainBetweenDAGAndOperatorNotAllowedRule
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14982:
URL: https://github.com/apache/airflow/pull/14982#issuecomment-808181377
re-triggering ci.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14982: Recognize more ways to import DAG in ChainBetweenDAGAndOperatorNotAllowedRule
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14982:
URL: https://github.com/apache/airflow/pull/14982#issuecomment-808184259
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb closed pull request #14982: Recognize more ways to import DAG in ChainBetweenDAGAndOperatorNotAllowedRule
Posted by GitBox <gi...@apache.org>.
ashb closed pull request #14982:
URL: https://github.com/apache/airflow/pull/14982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org