You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/02/17 18:37:28 UTC
[kudu-CR] [security] add --rpc tls min protocol flag
Hello Todd Lipcon, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6059
to review the following change.
Change subject: [security] add --rpc_tls_min_protocol flag
......................................................................
[security] add --rpc_tls_min_protocol flag
Allows administrators to configure the minimum TLS protocol version. We
default to TLSv1 in order to support ancient versions of RHEL out of the
box, but clusters which don't need to support C++ clients or servers on
RHEL 6.5 or below should set this flag to TLSv1.2.
Change-Id: I5785a22102f1c9aa083e63aefdd1cdfdd43ede9f
---
M src/kudu/security/tls_context.cc
1 file changed, 32 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/6059/1
--
To view, visit http://gerrit.cloudera.org:8080/6059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5785a22102f1c9aa083e63aefdd1cdfdd43ede9f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [security] add --rpc tls min protocol flag
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: [security] add --rpc_tls_min_protocol flag
......................................................................
[security] add --rpc_tls_min_protocol flag
Allows administrators to configure the minimum TLS protocol version. We
default to TLSv1 in order to support ancient versions of RHEL out of the
box, but clusters which don't need to support C++ clients or servers on
RHEL 6.5 or below should set this flag to TLSv1.2.
Change-Id: I5785a22102f1c9aa083e63aefdd1cdfdd43ede9f
Reviewed-on: http://gerrit.cloudera.org:8080/6059
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/security/tls_context.cc
1 file changed, 31 insertions(+), 3 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5785a22102f1c9aa083e63aefdd1cdfdd43ede9f
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [security] add --rpc tls min protocol flag
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [security] add --rpc_tls_min_protocol flag
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6059/1/src/kudu/security/tls_context.cc
File src/kudu/security/tls_context.cc:
Line 109: long options = SSL_OP_NO_SSLv2 | SSL_OP_NO_SSLv3 | SSL_OP_NO_COMPRESSION;
> warning: consider replacing 'long' with 'int64' [google-runtime-int]
It's defined as a long in the OpenSSL API, so I think this would be incorrect to change.
--
To view, visit http://gerrit.cloudera.org:8080/6059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5785a22102f1c9aa083e63aefdd1cdfdd43ede9f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [security] add --rpc tls min protocol flag
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [security] add --rpc_tls_min_protocol flag
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6059/1/src/kudu/security/tls_context.cc
File src/kudu/security/tls_context.cc:
Line 109: long options = SSL_OP_NO_SSLv2 | SSL_OP_NO_SSLv3 | SSL_OP_NO_COMPRESSION;
> It's defined as a long in the OpenSSL API, so I think this would be incorre
ugh this is faililng lint so I'll justchange it to auto. Hopefully that does the right hing.
--
To view, visit http://gerrit.cloudera.org:8080/6059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5785a22102f1c9aa083e63aefdd1cdfdd43ede9f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [security] add --rpc tls min protocol flag
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6059
to look at the new patch set (#2).
Change subject: [security] add --rpc_tls_min_protocol flag
......................................................................
[security] add --rpc_tls_min_protocol flag
Allows administrators to configure the minimum TLS protocol version. We
default to TLSv1 in order to support ancient versions of RHEL out of the
box, but clusters which don't need to support C++ clients or servers on
RHEL 6.5 or below should set this flag to TLSv1.2.
Change-Id: I5785a22102f1c9aa083e63aefdd1cdfdd43ede9f
---
M src/kudu/security/tls_context.cc
1 file changed, 32 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/6059/2
--
To view, visit http://gerrit.cloudera.org:8080/6059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5785a22102f1c9aa083e63aefdd1cdfdd43ede9f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [security] add --rpc tls min protocol flag
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6059
to look at the new patch set (#4).
Change subject: [security] add --rpc_tls_min_protocol flag
......................................................................
[security] add --rpc_tls_min_protocol flag
Allows administrators to configure the minimum TLS protocol version. We
default to TLSv1 in order to support ancient versions of RHEL out of the
box, but clusters which don't need to support C++ clients or servers on
RHEL 6.5 or below should set this flag to TLSv1.2.
Change-Id: I5785a22102f1c9aa083e63aefdd1cdfdd43ede9f
---
M src/kudu/security/tls_context.cc
1 file changed, 31 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/6059/4
--
To view, visit http://gerrit.cloudera.org:8080/6059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5785a22102f1c9aa083e63aefdd1cdfdd43ede9f
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [security] add --rpc tls min protocol flag
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [security] add --rpc_tls_min_protocol flag
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5785a22102f1c9aa083e63aefdd1cdfdd43ede9f
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No