You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "XorSum (via GitHub)" <gi...@apache.org> on 2024/06/18 11:29:02 UTC
[PR] [KYUUBI #6302][FOLLOWUP] skip job group cancellation on incremental collect mode [kyuubi]
XorSum opened a new pull request, #6482:
URL: https://github.com/apache/kyuubi/pull/6482
# :mag: Description
## Issue References ๐
<!-- Append the issue number after #. If there is no issue for you to link create one or -->
<!-- If there are no issues to link, please provide details here. -->
This pull request fixes https://github.com/apache/kyuubi/pull/6473#discussion_r1642652411
## Describe Your Solution ๐ง
add a configuration to control whether to skip the cancellation here for incremental collect queries, skipping by default for safety.
## Types of changes :bookmark:
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
## Test Plan ๐งช
#### Behavior Without This Pull Request :coffin:
#### Behavior With This Pull Request :tada:
#### Related Unit Tests
---
# Checklist ๐
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)
**Be nice. Be informative.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #6302][FOLLOWUP] skip job group cancellation on incremental collect mode [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #6482:
URL: https://github.com/apache/kyuubi/pull/6482#discussion_r1644476123
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -2761,6 +2761,14 @@ object KyuubiConf {
.version("1.10.0")
.fallbackConf(OPERATION_INCREMENTAL_COLLECT)
+ val ENGINE_SPARK_OPERATION_INCREMENTAL_COLLECT_SKIP_CANCEL_GROUP: ConfigEntry[Boolean] =
+ buildConf("kyuubi.engine.spark.operation.incremental.collect.skip.cancel.group")
+ .doc("When true, the job group cancellation in executeStatement method " +
+ "will be skipped on incremental collect mode")
Review Comment:
rather than repeating information that is easily inferred from the configuration name, the documentation should be enriched to explain why should this configuration be introduced and when should it be adjusted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #6302][FOLLOWUP] skip job group cancellation on incremental collect mode [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #6482:
URL: https://github.com/apache/kyuubi/pull/6482#discussion_r1644474972
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -2761,6 +2761,14 @@ object KyuubiConf {
.version("1.10.0")
.fallbackConf(OPERATION_INCREMENTAL_COLLECT)
+ val ENGINE_SPARK_OPERATION_INCREMENTAL_COLLECT_SKIP_CANCEL_GROUP: ConfigEntry[Boolean] =
+ buildConf("kyuubi.engine.spark.operation.incremental.collect.skip.cancel.group")
Review Comment:
let rename it and mark it as internal, in most cases, users should not tune it.
```
kyuubi.engine.spark.operation.incremental.collect.cancelJobGroupAfterExecutionFinished
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org