[PATCH] replace `array_header' with `table' in mod_proxy

[Martin Kraemer <Ma...@mch.sni.de>]

This patch tries to replace all occurences of array_header* with the
equivalent table* functions. It is part of a cleanup which I would
like to see in 1.3.2 in conjunction with the Via: patches. Without them,
I will have to cast between array_header* and table* at several places,
which I'd prefer to avoid.

In general, using table* makes the code clearer and easier, but with
mod_proxy, one needs a bush knife anyways.

However I *fear* I overdid it and modified too much while I was at it.
Whaddya think?

    Martin
-- 
| S I E M E N S |  <Ma...@mch.sni.de>  |      Siemens Nixdorf
| ------------- |   Voice: +49-89-636-46021     |  Informationssysteme AG
| N I X D O R F |   FAX:   +49-89-636-44994     |   81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request

Re: [PATCH] replace `array_header' with `table' in mod_proxy

[Dean Gaudet <dg...@arctic.org>]

BTW, if while you're doing this you find the proxy does something with
tables which we don't already support elsewhere it's probably worth it to
move it into util.c... rather than just keeping them in proxy_util.c.  I
remember trying to start this massive cleanup a few times, and giving up
in disgust.

Another BTW... I sort of gave up on the proxy in apache-nspr... so when
you're done with this it's probably easiest to just re-port the entire
module to NSPR.  I gave up because I was finding it really hard to stop
myself from rewriting vast portions of the proxy... and since I don't ever
test the proxy that's a bad idea ;)

Dean

On Wed, 22 Jul 1998, Dean Gaudet wrote:

> Oh! yes!  Cleanup is good.  I say go for it. 
> 
> Dean
> 
> On Wed, 22 Jul 1998, Martin Kraemer wrote:
> 
> > This patch tries to replace all occurences of array_header* with the
> > equivalent table* functions. It is part of a cleanup which I would
> > like to see in 1.3.2 in conjunction with the Via: patches. Without them,
> > I will have to cast between array_header* and table* at several places,
> > which I'd prefer to avoid.
> > 
> > In general, using table* makes the code clearer and easier, but with
> > mod_proxy, one needs a bush knife anyways.
> > 
> > However I *fear* I overdid it and modified too much while I was at it.
> > Whaddya think?
> > 
> >     Martin
> > -- 
> > | S I E M E N S |  <Ma...@mch.sni.de>  |      Siemens Nixdorf
> > | ------------- |   Voice: +49-89-636-46021     |  Informationssysteme AG
> > | N I X D O R F |   FAX:   +49-89-636-44994     |   81730 Munich, Germany
> > ~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request
> > 
> 

Re: [PATCH] replace `array_header' with `table' in mod_proxy

[Dean Gaudet <dg...@arctic.org>]

Oh! yes!  Cleanup is good.  I say go for it. 

Dean

On Wed, 22 Jul 1998, Martin Kraemer wrote:

> This patch tries to replace all occurences of array_header* with the
> equivalent table* functions. It is part of a cleanup which I would
> like to see in 1.3.2 in conjunction with the Via: patches. Without them,
> I will have to cast between array_header* and table* at several places,
> which I'd prefer to avoid.
> 
> In general, using table* makes the code clearer and easier, but with
> mod_proxy, one needs a bush knife anyways.
> 
> However I *fear* I overdid it and modified too much while I was at it.
> Whaddya think?
> 
>     Martin
> -- 
> | S I E M E N S |  <Ma...@mch.sni.de>  |      Siemens Nixdorf
> | ------------- |   Voice: +49-89-636-46021     |  Informationssysteme AG
> | N I X D O R F |   FAX:   +49-89-636-44994     |   81730 Munich, Germany
> ~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request
>