[GitHub] [trafficserver] bneradt commented on a diff in pull request #10474: add conveinience function to lookup name->IntType*

["bneradt (via GitHub)" <gi...@apache.org>]

bneradt commented on code in PR #10474:
URL: https://github.com/apache/trafficserver/pull/10474#discussion_r1333461581


##########
include/api/Metrics.h:
##########
@@ -88,6 +89,16 @@ class Metrics
   IdType lookup(const std::string_view name) const;
   IntType *lookup(IdType id, std::string_view *name = nullptr) const;
 
+  std::optional<IntType *>
+  lookupPtr(const std::string_view name) const

Review Comment:
   A const string_view strikes me as odd, but I see it is done elsewhere in the file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org