You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by Justin Mclean <ju...@classsoftware.com> on 2019/06/01 03:29:57 UTC
Re: [VOTE] Apache Tuweni (incubating) 0.7.0
Hi,
-1 for missing DISCLAIMER, GPL source code in the release and a compiled code in the release.
I suggest you use a checklist like this one to help you. [1]. This page is also very useful when making your license and notice filed [2].
If you need any help or want the IPMC to check think before you make a release just ask.
I checked:
- incubating in name
- DISCLAIMER is missing
- LICENSE is missing a number of things (see below)
- NOTICE contains license information that should be in LICENSE
- Source file have ASF headers
- There’s an unexpected binary file in the release [11]
- THE GPL licensed content in the release
- I didn’t try to compile the code
LICENSE is missing license:
- for this this file [3] which may be this [4]
- this file [5] which also include has two headers.
- in the directory of [5] other files have ASF headers and I’m wondering if they should, looking at [6] it mention this link [7] which is GPL licensed [8]. GPL licensed code can’t be included in a source release,
- several files like this one [9] which are MIT licenses
This file [10] (and I assume others in that directory) is also GPL licensed.
Thanks,
Justin
1. https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
2. http://www.apache.org/dev/licensing-howto.html
3. ./tuweni-src-0.7.0/progpow/src/main/java/org/apache/tuweni/progpow/Keccakf800.java
4. https://github.com/bcgit/bc-java/blob/master/LICENSE.html
5. ./tuweni-src-0.7.0/scuttlebutt-rpc/src/test/java/org/apache/tuweni/scuttlebutt/rpc/mux/PatchworkIntegrationTest.java
6../progpow/src/main/java/org/apache/tuweni/progpow/ProgPoW.java
7. https://github.com/ifdefelse/ProgPOW
8. https://github.com/ifdefelse/ProgPOW/blob/master/LICENSE
9. ./toml/src/test/resources/org/apache/tuweni/toml/hard_example.toml
10. ./eth-reference-tests/src/test/resources/tests/ansible/ec2.py
11. ./gradle/wrapper/gradle-wrapper.jar
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Apache Tuweni (incubating) 0.7.0
Posted by Antoine Toulme <an...@toulme.name>.
OK thanks for the review.
I have applied some of the fixes here:
https://github.com/apache/incubator-tuweni/commit/fa12f390165559a4afaf522c02672adbcd9dfb67 <https://github.com/apache/incubator-tuweni/commit/fa12f390165559a4afaf522c02672adbcd9dfb67>
I’ll open another thread to discuss.
> On May 31, 2019, at 8:29 PM, Justin Mclean <ju...@classsoftware.com> wrote:
>
> Hi,
>
> -1 for missing DISCLAIMER, GPL source code in the release and a compiled code in the release.
>
> I suggest you use a checklist like this one to help you. [1]. This page is also very useful when making your license and notice filed [2].
>
> If you need any help or want the IPMC to check think before you make a release just ask.
>
> I checked:
> - incubating in name
> - DISCLAIMER is missing
> - LICENSE is missing a number of things (see below)
> - NOTICE contains license information that should be in LICENSE
> - Source file have ASF headers
> - There’s an unexpected binary file in the release [11]
> - THE GPL licensed content in the release
> - I didn’t try to compile the code
>
> LICENSE is missing license:
> - for this this file [3] which may be this [4]
> - this file [5] which also include has two headers.
> - in the directory of [5] other files have ASF headers and I’m wondering if they should, looking at [6] it mention this link [7] which is GPL licensed [8]. GPL licensed code can’t be included in a source release,
> - several files like this one [9] which are MIT licenses
>
> This file [10] (and I assume others in that directory) is also GPL licensed.
>
> Thanks,
> Justin
>
> 1. https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> 2. http://www.apache.org/dev/licensing-howto.html
> 3. ./tuweni-src-0.7.0/progpow/src/main/java/org/apache/tuweni/progpow/Keccakf800.java
> 4. https://github.com/bcgit/bc-java/blob/master/LICENSE.html
> 5. ./tuweni-src-0.7.0/scuttlebutt-rpc/src/test/java/org/apache/tuweni/scuttlebutt/rpc/mux/PatchworkIntegrationTest.java
> 6../progpow/src/main/java/org/apache/tuweni/progpow/ProgPoW.java
> 7. https://github.com/ifdefelse/ProgPOW
> 8. https://github.com/ifdefelse/ProgPOW/blob/master/LICENSE
> 9. ./toml/src/test/resources/org/apache/tuweni/toml/hard_example.toml
> 10. ./eth-reference-tests/src/test/resources/tests/ansible/ec2.py
> 11. ./gradle/wrapper/gradle-wrapper.jar
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
Re: [VOTE] Apache Tuweni (incubating) 0.7.0
Posted by Antoine Toulme <an...@toulme.name>.
OK, the vote is now closed. The vote does not pass with 2 -1 votes from Dave Fisher and Justin Mclean.
Thank you all for your feedback. I will take you up on the offer of helping draw the release.
> On May 31, 2019, at 10:01 PM, Justin Mclean <ju...@classsoftware.com> wrote:
>
> Hi,
>
>> This class is not GPL. It was written by me. It is based on the ProgPoW algorithm specification. That specification is licensed CC0, scroll to the bottom of the README please: https://github.com/ifdefelse/ProgPOW/blob/master/README.md
>
> Thanks for clarifying that, you might want to make that clear in the LICENSE file in that repo.
>
> Thanks,
> Justin
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Apache Tuweni (incubating) 0.7.0
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> This class is not GPL. It was written by me. It is based on the ProgPoW algorithm specification. That specification is licensed CC0, scroll to the bottom of the README please: https://github.com/ifdefelse/ProgPOW/blob/master/README.md
Thanks for clarifying that, you might want to make that clear in the LICENSE file in that repo.
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Apache Tuweni (incubating) 0.7.0
Posted by Antoine Toulme <an...@toulme.name>.
Hi Justin,
This class is not GPL. It was written by me. It is based on the ProgPoW algorithm specification. That specification is licensed CC0, scroll to the bottom of the README please: https://github.com/ifdefelse/ProgPOW/blob/master/README.md
I’ll address the other points separately.
> On May 31, 2019, at 20:29, Justin Mclean <ju...@classsoftware.com> wrote:
>
> Hi,
>
> -1 for missing DISCLAIMER, GPL source code in the release and a compiled code in the release.
>
> I suggest you use a checklist like this one to help you. [1]. This page is also very useful when making your license and notice filed [2].
>
> If you need any help or want the IPMC to check think before you make a release just ask.
>
> I checked:
> - incubating in name
> - DISCLAIMER is missing
> - LICENSE is missing a number of things (see below)
> - NOTICE contains license information that should be in LICENSE
> - Source file have ASF headers
> - There’s an unexpected binary file in the release [11]
> - THE GPL licensed content in the release
> - I didn’t try to compile the code
>
> LICENSE is missing license:
> - for this this file [3] which may be this [4]
> - this file [5] which also include has two headers.
> - in the directory of [5] other files have ASF headers and I’m wondering if they should, looking at [6] it mention this link [7] which is GPL licensed [8]. GPL licensed code can’t be included in a source release,
> - several files like this one [9] which are MIT licenses
>
> This file [10] (and I assume others in that directory) is also GPL licensed.
>
> Thanks,
> Justin
>
> 1. https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> 2. http://www.apache.org/dev/licensing-howto.html
> 3. ./tuweni-src-0.7.0/progpow/src/main/java/org/apache/tuweni/progpow/Keccakf800.java
> 4. https://github.com/bcgit/bc-java/blob/master/LICENSE.html
> 5. ./tuweni-src-0.7.0/scuttlebutt-rpc/src/test/java/org/apache/tuweni/scuttlebutt/rpc/mux/PatchworkIntegrationTest.java
> 6../progpow/src/main/java/org/apache/tuweni/progpow/ProgPoW.java
> 7. https://github.com/ifdefelse/ProgPOW
> 8. https://github.com/ifdefelse/ProgPOW/blob/master/LICENSE
> 9. ./toml/src/test/resources/org/apache/tuweni/toml/hard_example.toml
> 10. ./eth-reference-tests/src/test/resources/tests/ansible/ec2.py
> 11. ./gradle/wrapper/gradle-wrapper.jar
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>