[jira] [Commented] (CAMEL-11343) gRPC component cannot load service class

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-11343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026415#comment-16026415 ] 

ASF GitHub Bot commented on CAMEL-11343:
----------------------------------------

GitHub user dmvolod opened a pull request:

    https://github.com/apache/camel/pull/1721

    CAMEL-11343: gRPC component cannot load service class

    Changing from Class.forName to context.getClassResolver().resolveMandatoryClass which is working in modular environments (OSGi, JavaEE, etc)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dmvolod/camel CAMEL-11343

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1721.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1721
    
----
commit 30559d2dd63300ff86b51e6dda081d75d0fed456
Author: Dmitry Volodin <dm...@gmail.com>
Date:   2017-05-26T15:35:55Z

    CAMEL-11343: gRPC component cannot load service class

----


> gRPC component cannot load service class
> ----------------------------------------
>
>                 Key: CAMEL-11343
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11343
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-grpc
>    Affects Versions: 2.19.0
>            Reporter: James Netherton
>            Assignee: Dmitry Volodin
>             Fix For: 2.19.1, 2.20.0
>
>
> Class {{GrpcUtils}} does:
> {code}
> Class grpcServiceClass = Class.forName(serviceClassName);
> {code}
> Unfortunately, that causes the class loading to be done from the {{GrpcUtils}} {{ClassLoader}}, which may not be appropriate in modular environments (OSGi, JavaEE, etc)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)