You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/05/09 07:47:42 UTC
[GitHub] [incubator-seatunnel] felixYyu opened a new pull request, #1834: [Bug][seatunnel-core]slf4j instead System.out.println
felixYyu opened a new pull request, #1834:
URL: https://github.com/apache/incubator-seatunnel/pull/1834
Closes #1833
the CheckStyle rule ，I think it should slf4j instead System.out.println.
> Prohibit invoking System.out.println in source code !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] felixYyu closed pull request #1834: [Bug][seatunnel-core]slf4j instead System.out.println
Posted by GitBox <gi...@apache.org>.
felixYyu closed pull request #1834: [Bug][seatunnel-core]slf4j instead System.out.println
URL: https://github.com/apache/incubator-seatunnel/pull/1834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] felixYyu commented on pull request #1834: [Bug][seatunnel-core]slf4j instead System.out.println
Posted by GitBox <gi...@apache.org>.
felixYyu commented on PR #1834:
URL: https://github.com/apache/incubator-seatunnel/pull/1834#issuecomment-1121844794
If must need to use `System.out`, I'll close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1834: [Bug][seatunnel-core]slf4j instead System.out.println
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #1834:
URL: https://github.com/apache/incubator-seatunnel/pull/1834#issuecomment-1120879671
@felixYyu Hi, the Starter is used to generate flink/spark command. If we use log here, the return info will look like below, we need to parse the command from the log, so we need to use `System.out` here. You can't change this, but you can add a comment on the `System.out` to explain this.
```
22/05/09 14:30:58 INFO SparkStarter: xx
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org