You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2014/02/14 09:47:22 UTC

[jira] [Commented] (ISIS-696) Extra overload for BookmarkService for lookup with downcast (making more consistent with API of MementoService).

    [ https://issues.apache.org/jira/browse/ISIS-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13901231#comment-13901231 ] 

ASF subversion and git services commented on ISIS-696:
------------------------------------------------------

Commit e84537f9b554efea08f7b67f54ba9143aa0cb2da in branch refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e84537f ]

ISIS-696: BookmarkService#lookup(Bookmark, Class<T>)


> Extra overload for BookmarkService for lookup with downcast (making more consistent with API of MementoService).
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: ISIS-696
>                 URL: https://issues.apache.org/jira/browse/ISIS-696
>             Project: Isis
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: core-1.3.0
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>            Priority: Trivial
>             Fix For: core-1.4.0
>
>
> MementoService provides accessor methods in the form:
> <T> T MementoService#get(String,Class<T>)
> where the Class<T> is used to check the type of the accessed value within the memento, and to downcast appropriately.
> In BookmarkService, the lookup method is simply:
> Object BookmarkService#lookup(Bookmark)
> Instead, suggest:
> <T> T BookmarkService#lookup(Bookmark, Class<T>)



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)