[GitHub] [cordova-plugin-media-capture] ath0mas opened a new pull request #232: Android: Prevent app crash caused by NPE on intent data or mediaFile

[GitBox <gi...@apache.org>]

ath0mas opened a new pull request #232:
URL: https://github.com/apache/cordova-plugin-media-capture/pull/232


   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   Android
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   Prevent app crash after capture and show error if no content or no access to it
   
   
   ### Description
   <!-- Describe your changes in detail -->
   1. minimal fix #215 
   Unify null checks for all three capture types, first on retrieved intent data uri (failing with `CAPTURE_NO_MEDIA_FILES`), and then on no mediaFile created (failing with `CAPTURE_INTERNAL_ERR`)
   1. Simplify how video uri is retrieved from Video capture intent (see #210 comment)
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   App crashing because of audio capture in some conditions (see #227 comment) now resolves with failure instead.
   Not perfect, expecting #215 work on FileProvider to solve the problem but for now it is not an app crash anymore.
   
   
   ### Checklist
   
   - [ ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org