You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by felixcheung <gi...@git.apache.org> on 2017/05/26 06:06:50 UTC

[GitHub] spark pull request #18025: [SPARK-20889][SparkR] Grouped documentation for A...

Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18025#discussion_r118639090
  
    --- Diff: R/pkg/R/generics.R ---
    @@ -1403,20 +1416,25 @@ setGeneric("unix_timestamp", function(x, format) { standardGeneric("unix_timesta
     #' @export
     setGeneric("upper", function(x) { standardGeneric("upper") })
     
    -#' @rdname var
    +#' @rdname column_aggregate_functions
    +#' @param y,na.rm,use currently not used.
    --- End diff --
    
    should this be moved like this line https://github.com/apache/spark/pull/18025/files#diff-8e3d61ff66c9ffcd6ffb7a8eedc08409L923


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org