You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/01 12:21:00 UTC
[jira] [Commented] (FLINK-7320) Remove Flink's futures from
Scheduler
[ https://issues.apache.org/jira/browse/FLINK-7320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108804#comment-16108804 ]
ASF GitHub Bot commented on FLINK-7320:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4435#discussion_r130591837
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/Scheduler.java ---
@@ -152,12 +150,14 @@ else if (ret instanceof Future) {
}
}
catch (NoResourceAvailableException e) {
- return FlinkCompletableFuture.completedExceptionally(e);
+ CompletableFuture<SimpleSlot> notEnoughResources = new CompletableFuture<>();
--- End diff --
I actually did in one of the other up PRs. I'll try to merge this one first and then adapt the code here.
> Remove Flink's futures from Scheduler
> -------------------------------------
>
> Key: FLINK-7320
> URL: https://issues.apache.org/jira/browse/FLINK-7320
> Project: Flink
> Issue Type: Sub-task
> Components: Scheduler
> Affects Versions: 1.4.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
> Fix For: 1.4.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)