You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by wuchong <gi...@git.apache.org> on 2017/06/23 08:34:32 UTC
[GitHub] flink pull request #4171: [FLINK-6887] [table] Split up CodeGenerator into s...
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/4171
[FLINK-6887] [table] Split up CodeGenerator into several specific CodeGenerator
Currently, the `CodeGenerator` is very huge and a bit difficult to maintain. This PR splits it up into several specific `XXXCodeGenerator`. Including `FunctionCodeGenerator`, `AggregationCodeGenerator`, `CollectorCodeGenerator`, `InputFormatCodeGenerator`, and maybe `CEPCodeGenerator` will be added in the future.
This may influence many other PRs, so I would like it to be reviewed ASAP. @fhueske @twalthr
Thanks,
Jark Wu
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wuchong/flink codegen
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4171.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4171
----
commit 7ddb33b361cfe2f91c6228c518f02395420a16e6
Author: Jark Wu <wu...@alibaba-inc.com>
Date: 2017-06-23T08:29:20Z
[FLINK-6887] [table] Split up CodeGenerator into several specific CodeGenerator
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4171: [FLINK-6887] [table] Split up CodeGenerator into s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4171
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4171: [FLINK-6887] [table] Split up CodeGenerator into s...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4171#discussion_r127444349
--- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonCorrelate.scala ---
@@ -155,7 +155,7 @@ trait CommonCorrelate {
// The generated expression is discarded.
generator.generateExpression(condition.get.accept(changeInputRefIndexShuttle))
- val filterGenerator = new CodeGenerator(config, false, udtfTypeInfo, None, pojoFieldMapping)
+ val filterGenerator = new FunctionCodeGenerator(config, false, udtfTypeInfo, None, pojoFieldMapping)
--- End diff --
line exceeds limit of 100 chars
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4171: [FLINK-6887] [table] Split up CodeGenerator into several ...
Posted by wuchong <gi...@git.apache.org>.
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4171
@fhueske thanks for reviewing. I had fixed the code style issue.
I will merge this once the CI pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---