You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "Siegfried Goeschl (JIRA)" <ji...@apache.org> on 2011/09/18 21:35:09 UTC
[jira] [Commented] (JSPWIKI-626) The "createPages" WikiPemission is
not properly implemented
[ https://issues.apache.org/jira/browse/JSPWIKI-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107516#comment-13107516 ]
Siegfried Goeschl commented on JSPWIKI-626:
-------------------------------------------
I disagree here strongly since there are many 2.8.x users out there and it makes JSPWiki vulnerable to spam. Having said that I came across JPSWIKI-702 when setting up a public wiki so my opinion might be not entirely objective - I would have a hard time when running a public facing wiki to explain that this problem "is not worth the effort"
> The "createPages" WikiPemission is not properly implemented
> -----------------------------------------------------------
>
> Key: JSPWIKI-626
> URL: https://issues.apache.org/jira/browse/JSPWIKI-626
> Project: JSPWiki
> Issue Type: Bug
> Components: Authentication&Authorization
> Affects Versions: 2.6.2, 2.6.3, 2.6.4, 2.8, 2.8.1, 2.8.2, 2.8.3
> Reporter: Weijian Fang
>
> When the "edit" PagePermission is given, users can create pages even without the "createPages" WikiPermission.
> According to Andrew Jaquith:
> "Just checked the code in Edit.jsp and a few related classes
> (PageCommand and WikiContext).
> It turns out that we don't actually check for the "createPages"
> WikiPermission in Edit.jsp -- we only check for the "edit"
> PagePermission. So that means that if a user can edit pages, they can
> create them also. The Permission code itself is solid, but the JSP
> code that asks for the permissions to check isn't correct.
> This is a bug. In theory, we should fix this by asking first if the
> page already exists, and if it doesn't, checking for the "createPages"
> WikiPermission before forwarding to the editor. In practice, both
> permissions are usually granted to most users.
> We will fix this, for sure, in 3.0. I'm not sure if it is worth the
> effort in 2.8, but I'd like to get some additional opinions about this
> also."
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira